refactor/(abacrule): Replace blocking Await.result with non-blocking#2696
Merged
simonredfern merged 2 commits intoOpenBankProject:developfrom Feb 14, 2026
Merged
refactor/(abacrule): Replace blocking Await.result with non-blocking#2696simonredfern merged 2 commits intoOpenBankProject:developfrom
simonredfern merged 2 commits intoOpenBankProject:developfrom
Conversation
…Future composition in AbacRuleEngine Replace 16 Await.result calls in AbacRuleEngine.executeRule and executeRulesByPolicy with proper Future-based composition. Data fetches (user attributes, auth contexts, entitlements, bank/account/transaction/customer data) now run in parallel rather than sequentially blocking. Update call sites in APIMethods600 to consume the returned Future directly. Add AbacRuleTests covering both executeAbacRule and executeAbacPolicy endpoints (auth, role, success/failure, OR logic). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.