feat(dart): make requests abortable#23930
Open
timonrieger wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 14 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
wing328
reviewed
Jun 3, 2026
| /// * [Pet] pet (required): | ||
| /// Pet object that needs to be added to the store | ||
| Future<Response> addPetWithHttpInfo(Pet pet,) async { | ||
| Future<Response> addPetWithHttpInfo(Pet pet, { Future<void>? abortTrigger, }) async { |
Member
There was a problem hiding this comment.
thanks for the PR
is this PR backward compatible given the change (above) in method signature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows using the standard http.Client mechanism to abort requests, which is useful for both teardown and overall responsiveness.
port of immich-app/immich#28692
cc @mertalev
Dart: @yissachar
Dart (refactor): @joernahrens
Dart 2: @swipesight
Dart (Jaguar): @jaumard
Dart (Dio): @josh-burton
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.