Skip to content

feat(dart): make requests abortable#23930

Open
timonrieger wants to merge 3 commits into
OpenAPITools:masterfrom
timonrieger:dart/abortable-client
Open

feat(dart): make requests abortable#23930
timonrieger wants to merge 3 commits into
OpenAPITools:masterfrom
timonrieger:dart/abortable-client

Conversation

@timonrieger
Copy link
Copy Markdown
Contributor

@timonrieger timonrieger commented Jun 2, 2026

allows using the standard http.Client mechanism to abort requests, which is useful for both teardown and overall responsiveness.

port of immich-app/immich#28692

cc @mertalev

Dart: @yissachar
Dart (refactor): @joernahrens
Dart 2: @swipesight
Dart (Jaguar): @jaumard
Dart (Dio): @josh-burton

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 14 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

/// * [Pet] pet (required):
/// Pet object that needs to be added to the store
Future<Response> addPetWithHttpInfo(Pet pet,) async {
Future<Response> addPetWithHttpInfo(Pet pet, { Future<void>? abortTrigger, }) async {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR

is this PR backward compatible given the change (above) in method signature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants