Skip to content

[Python] fix constraint settings for decimalType#23928

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:python-constraint-settings
Jun 3, 2026
Merged

[Python] fix constraint settings for decimalType#23928
wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:python-constraint-settings

Conversation

@Mattias-Sehlstedt
Copy link
Copy Markdown
Contributor

@Mattias-Sehlstedt Mattias-Sehlstedt commented Jun 2, 2026

Fixes Python constraints where less than and greater than were inverted.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11)


Summary by cubic

Fixes inverted numeric constraints for Python decimal fields and unifies constraint handling across numeric types. Adds tests to verify correct pydantic Field parameters for integers, numbers, doubles, and decimals.

  • Bug Fixes

    • Correctly map Decimal constraints: exclusiveMinimum → gt, exclusiveMaximum → lt, minimum → ge, maximum → le.
    • Added unit test using format.yaml to assert expected Field(...) annotations, including decimal.
  • Refactors

    • Introduced shared applyConstraints for numeric types (int, decimal) and standardized imports via PYDANTIC/TYPING constants.
    • Validated mapNumberTo against a supported set and improved the error message for invalid values.

Written for commit 29d63a2. Summary will update on new commits.

Review in cubic

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 3, 2026

lgtm. thanks for the fix

@wing328 wing328 merged commit c4cd89a into OpenAPITools:master Jun 3, 2026
15 checks passed
@Mattias-Sehlstedt Mattias-Sehlstedt deleted the python-constraint-settings branch June 3, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants