fix(Kotlin): use the global apiNamePrefix and apiNameSuffix settings instead of apiSuffix (generator's option)#23926
Merged
wing328 merged 1 commit intoJun 3, 2026
Conversation
a162fb8 to
25a101a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes (#23822)
As discussed in #23834 opened PR for master aswell as the change has a fallback.
Removes Kotlin specific apiSuffix additionalSetting.
Adds support for global apiNamePrefix and apiNameSuffix settings to the kotlin generator.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Kotlin comittee members:
@karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) @dennisameling (2026/02)
Summary by cubic
Kotlin generators now use the global
apiNamePrefixandapiNameSuffixfor API class names, replacing the Kotlin-onlyapiSuffix. Default behavior is unchanged: classes end withApi, and empty names produceDefaultApi.Bug Fixes
AbstractKotlinCodegen.toApiNamenow builds names as prefix + camelized name + suffix; empty names returnDefaultApi.apiSuffixacross the codebase (includingCodegenConstants, generator options, docs, and tests). Added tests for prefix, suffix, and prefix+suffix.Migration
-DapiSuffix=Foowith-DapiNameSuffix=Foo(and-DapiNamePrefix=Barif needed). No change if you use the defaultApisuffix.Written for commit 25a101a. Summary will update on new commits.