Feature/detect generics allof fix

[Picazsoo]

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

---

Summary by cubic

Add generic schema substitution to spring and kotlin-spring to collapse repeated wrapper schemas into real generics (e.g., ApiResponse), unify paged-model handling under the same system, and improve pageable validation and enum ergonomics. Adds discovery to suggest genericPatterns and updates docs and samples.

• New Features

  • genericPatterns: configure suffix/prefix patterns with slot/slotArray to substitute return and property types; safely suppress redundant schemas; works with schemaMapping, importMapping, and modelNamePrefix/modelNameSuffix.
  • discoverGenericPatterns: scan specs and log ready-to-copy suggestions (supports arrays like Page<T> and allOf-based shapes).
  • Unified paged models: paginated schemas are auto-detected and substituted (e.g., UserPage → Page<User>), with safe removal of orphaned meta-schemas.
  • useEnumValueInterface: generate a ValuedEnum<T> in configPackage and have all enums implement it; override via importMappings.ValuedEnum.
  • Codegen hook: prepareSupportingFile(bundle, file) to adjust per-file data. New docs at docs/customization-genericPatterns.md; sample configs and projects added for both generators.

• Bug Fixes

  • Preserve outer containers during substitution (e.g., List<UserResponse> → List<ApiResponse<User>>) and correctly handle array properties and imports.
  • Correct suppression and import syncing when modelNamePrefix/modelNameSuffix is set; honor explicit schemaMapping overrides.
  • Pageable: add minSize/minPage; resolve min/max and defaults through nested allOf; apply annotations consistently; limit Pageable features to Spring Boot libraries and update docs.
  • Safer schema suppression by checking references across operations, models, and imports.
  • Kotlin enums: avoid emitting override val value for container inline enums when useEnumValueInterface is on (fixes “overrides nothing”); bind useEnumValueInterface from additionalProperties so the feature actually generates ValuedEnum and implements it.
  • Generator: only call prepareSupportingFile for files that will render and reset per-file data to prevent leakage between supporting files (stabilizes Mode B genericClass generation).
  • Code health: fix ArchUnit logger rule violations by scoping loggers correctly.

^{Written for commit 7c9a072. Summary will update on new commits.}

[cubic-dev-ai]

5 issues found across 107 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/server/petstore/kotlin-springboot-generics/build.gradle.kts">

<violation number="1" location="samples/server/petstore/kotlin-springboot-generics/build.gradle.kts:3">
P1: Move the `plugins` block to the top of `build.gradle.kts`; Gradle requires it before other build logic, and the current order can break script evaluation.</violation>
</file>

<file name="modules/openapi-generator/src/main/resources/kotlin-spring/validPageable.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/kotlin-spring/validPageable.mustache:61">
P2: Add a fail-fast configuration check so `min*` cannot be greater than `max*` when both limits are set.</violation>
</file>

<file name="samples/server/petstore/kotlin-springboot-generics/src/main/kotlin/org/openapitools/model/Order.kt">

<violation number="1" location="samples/server/petstore/kotlin-springboot-generics/src/main/kotlin/org/openapitools/model/Order.kt:27">
P2: `totalPrice` should not use `Double` for money values; use a decimal-safe type to avoid precision loss.</violation>
</file>

<sub>Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: Move the plugins block to the top of build.gradle.kts; Gradle requires it before other build logic, and the current order can break script evaluation.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At samples/server/petstore/kotlin-springboot-generics/build.gradle.kts, line 3:

<comment>Move the `plugins` block to the top of `build.gradle.kts`; Gradle requires it before other build logic, and the current order can break script evaluation.</comment>

<file context>
@@ -0,0 +1,48 @@
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
+
+group = "org.openapitools"
+version = "1.0.0"
+java.sourceCompatibility = JavaVersion.VERSION_17
</file context>

[cubic-dev-ai]

P2: totalPrice should not use Double for money values; use a decimal-safe type to avoid precision loss.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At samples/server/petstore/kotlin-springboot-generics/src/main/kotlin/org/openapitools/model/Order.kt, line 27:

<comment>`totalPrice` should not use `Double` for money values; use a decimal-safe type to avoid precision loss.</comment>

<file context>
@@ -0,0 +1,34 @@
+
+    @get:JsonProperty("quantity") val quantity: kotlin.Int? = null,
+
+    @get:JsonProperty("totalPrice") val totalPrice: kotlin.Double? = null
+) : java.io.Serializable {
+
</file context>

[cubic-dev-ai]

P2: Add a fail-fast configuration check so min* cannot be greater than max* when both limits are set.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/kotlin-spring/validPageable.mustache, line 61:

<comment>Add a fail-fast configuration check so `min*` cannot be greater than `max*` when both limits are set.</comment>

<file context>
@@ -45,10 +51,14 @@ class PageableConstraintValidator : ConstraintValidator<ValidPageable, Pageable>
         maxSize = constraintAnnotation.maxSize
         maxPage = constraintAnnotation.maxPage
+        minSize = constraintAnnotation.minSize
+        minPage = constraintAnnotation.minPage
     }
 
</file context>