Conversation
|
Openeo-geopyspark-driver PR: Open-EO/openeo-geopyspark-driver#1629 |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c23ca192a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
This MR only adds code, so can't really do something wrong. Besides the second review point, this looks good to me |
|
@Hneuschmidt Ok for me to merge already? The MR was in draft... |
|
Yes, we resolved the reasons it was in draft -> can be merged |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fa9fe99b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def load_stac(self, url: str, load_params: LoadParameters, env: EvalEnv) -> DriverDataCube: | ||
| raise NotImplementedError | ||
|
|
||
| def query_stac(self, url: str, spatial_extent: Union[Dict, BoundingBox, None], temporal_extent: Tuple[Optional[str], Optional[str]], _env: EvalEnv) -> DriverDataCube: |
There was a problem hiding this comment.
ProcessGraphDeserializer.query_stac calls env.backend_implementation.query_stac(..., env=env), but the new backend interface declares the parameter as _env; in Python keyword arguments must match exactly, so backends that inherit the default method (or call super()) will raise TypeError: unexpected keyword argument 'env' instead of the intended NotImplementedError path. This turns unsupported query_stac usage into an internal error rather than a predictable backend capability failure.
Useful? React with 👍 / 👎.
2 participants
Adds a new process "query_stac" which is a reduced and simplified version of "load_stac" which skips the "load" part of
load_stac-> the items returned by the catalog query are not loaded into a data cube but instead provided as-is.This is especially useful for processes that bypass the OpenEO data model and work on EO products directly, An example are processes based on OGC Best Practice Earth Observation Application Packages.
This PR is made in the context of integrating the FORCE EO Toolbox into the
openeo-geopyspark-driver, in the context of ESA's APEx project. The implementation serves this purpose first, FORCE needs to access EO products in in their raw format. However, the process was deemed general enough to be integrated as a general process.I am happy to receive any feedback on this PR, including choice of name for the process and placement in the repository.
@jdries @EmileSonneveld