chore: [SDK-4406] prepare Unity demo app for Appium E2E tests#869
Open
fadi-george wants to merge 52 commits into
Open
chore: [SDK-4406] prepare Unity demo app for Appium E2E tests#869fadi-george wants to merge 52 commits into
fadi-george wants to merge 52 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Row TextField names were derived from `_rows.Count` at construction time, but RemoveRow does not renumber survivors. After Add+Remove(middle)+Add, the new row's name collided with an existing survivor's name, and AccessibilityBridge.WalkAndUpsert dedupes by name (first-wins) — so the new row was silently dropped from the a11y tree and Appium taps landed on the stale row. Switch to a monotonic `_nextRowIndex++` so names are permanently unique regardless of remove ordering. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Prepare the Unity demo app for Appium E2E test automation by adding accessibility bridges, stabilizing UI element naming, and improving iOS/Android test reliability.
Details
Motivation
SDK-4406: enable Appium-driven E2E tests against the Unity demo app. Unity's UI Toolkit does not expose native accessibility identifiers, so Appium cannot reliably locate elements on iOS or Android. This PR adds native accessibility bridges (iOS and Android), standardizes UI element names, and fixes a number of demo-side bugs uncovered while wiring up the test harness.
Scope
examples/demo/is touched. No SDK source changes.AccessibilityBridgeplus iOS (OneSignalDemoKeyboard.mm) and Android (OneSignalUnityE2EAccessibility.java) native helpers used to expose UI elements to Appium.LogView/LogManager(replaced withDebug.Log), renamesTrackEventSectionControllertoCustomEventsSectionController, consolidates upsert helpers, replaces the loading overlay with inline loading states, and tightens dialog/keyboard behavior.Testing
Manual testing
./run-local.sh --sdk=unity --platform=android --spec="{01_,02_,03_}".--skip-buildfor01_through12_; all numbered specs passed.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor