fix: Otel logging misc fixes by jkasten2 · Pull Request #2539 · OneSignal/OneSignal-Android-SDK

jkasten2 · 2026-02-02T05:04:13Z

Description

One Line Summary

Misc fixes and clean up for the otel branch.

Details

Commits are atomic, recommend reviewer look them over in time order.

Motivation

Fixes required for launch

Scope

Only affect logging logic

Testing

Unit testing

Updated unit tests

Manual testing

Tested on Android 5, 6, and 14 emulators.

Affected code checklist

Checklist

Overview

I have filled out all REQUIRED sections above
PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
Any Public API changes are explained in the PR details and conform to existing APIs

Testing

I have included test coverage for these changes, or explained why they are not needed
All automated tests pass, or I explained why that is not possible
I have personally tested this on my device, or explained why that is not possible

Final pass

Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is

This was backwards causing ERROR to send everything

Simplified logic, cleaned up logging statements, and removed code comments that added no value.

Removed "old" format support, we never shipped that. Removed int format, we never shipped nor plan to change it. Removed "logLevel" field fallback, we will always just use "log_level"

In the context of remote logging this is "info", to the app developer this is more of a warning, however this is something we will develop later.

Looks like this was broke in a large refactor in commit 76460ee

Classes Otel depends on will be missing on Android 7 and older devices, or if the app is heavily minified. Added specific handling for this as well as an outer catch on Throwable so we at least allow any existing crash handlers to run.

We don't want logging to be the root cause of an app crash.

abdulraqeeb33

a few questions

...nesignal/core/src/main/java/com/onesignal/core/internal/backend/impl/ParamsBackendService.kt

...ignal/core/src/main/java/com/onesignal/debug/internal/crash/OneSignalCrashUploaderWrapper.kt

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/logging/Logging.kt

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalCrashLogInit.kt

OneSignalSDK/onesignal/otel/src/main/java/com/onesignal/otel/crash/OtelCrashHandler.kt

Copilot

Pull request overview

This PR contains miscellaneous fixes and improvements to the OpenTelemetry (Otel) logging infrastructure in preparation for launch. The changes include a type change for process uptime tracking, crash handler refactoring for better reliability, log level adjustments, and code cleanup.

Changes:

Changed processUptime from Double (seconds) to Long (milliseconds) and updated the calculation method
Refactored crash handler to ensure the existing exception handler is always called, even if OneSignal's crash handling fails
Adjusted several log levels from WARN to INFO to reduce noise for non-critical messages
Added Android version checks and improved error handling for Otel-specific code

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
IOtelPlatformProvider.kt	Changed processUptime type from Double (seconds) to Long (milliseconds)
OtelPlatformProvider.kt	Updated processUptime calculation to use Process.getStartUptimeMillis() for accurate process uptime measurement
OtelCrashHandler.kt	Refactored crash handling flow to ensure existing handler is always called; added NoClassDefFoundError catch block; improved error messages
OneSignalCrashLogInit.kt	Code cleanup and removed verbose comments; changed log level comparison logic; adjusted logging levels
Logging.kt	Added Android Oreo version check before Otel logging; changed exception catch from Exception to Throwable
OneSignalCrashUploaderWrapper.kt	Added Android Oreo version check and error handling wrapper for crash upload
ParamsBackendService.kt	Simplified log level parsing to only support string format
OneSignalImp.kt	Changed log level from WARN to INFO for main thread blocking warning
InAppMessagesManager.kt	Changed log level from WARN to INFO for paused state message
CrashReportUploadTest.kt	Updated test output to reflect milliseconds unit for process uptime
OtelFieldsPerEventTest.kt	Updated test mocks to use integer values for uptime (milliseconds)
OtelFactoryTest.kt	Updated test mock to use integer value for uptime
OtelPlatformProviderTest.kt	Updated test assertions to use proper comparison matchers
OtelIntegrationTest.kt	Updated test assertion to use proper comparison matcher

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalCrashLogInit.kt

...core/src/main/java/com/onesignal/debug/internal/logging/otel/android/OtelPlatformProvider.kt

OneSignalSDK/onesignal/otel/src/main/java/com/onesignal/otel/crash/OtelCrashHandler.kt

abdulraqeeb33 · 2026-02-09T17:07:59Z

...ignal/core/src/main/java/com/onesignal/debug/internal/crash/OneSignalCrashUploaderWrapper.kt

    override fun start() {
        // Otel library requires Android Oreo (8) or newer
-        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) return
+        if (AndroidUtils.androidSDKInt < Build.VERSION_CODES.O) return


What i meant was, you could have a AndroidLoggingUtils or something similar and that class basically has something like
boolean fn isOtelLoggingSupport()

and that does this check if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) return

Addresses review feedback to consolidate the scattered Build.VERSION.SDK_INT < Build.VERSION_CODES.O checks into a single OtelSdkSupport utility object. - OtelSdkSupport.isSupported replaces inline version checks in Logging, OneSignalCrashUploaderWrapper, and OneSignalCrashHandlerFactory - Factory now uses require() instead of returning a NoOpCrashHandler - OtelSdkSupport.isSupported is writable for unit tests - Removed Logging.androidVersion field (replaced by OtelSdkSupport) - Updated all affected tests Co-authored-by: Cursor <cursoragent@cursor.com>

- CrashReportUploadTest.kt: kept our version (new test for processUptime fix) - OneSignalCrashHandlerFactoryTest.kt: merged base's additional tests with OtelSdkSupport usage - OtelFieldsPerEventTest.kt: kept base's setupDefaultMocks helper with Long processUptime type Co-authored-by: Cursor <cursoragent@cursor.com>

Deleted in base branch by cleanup PR #2541. Co-authored-by: Cursor <cursoragent@cursor.com>

abdulraqeeb33 · 2026-02-24T22:52:29Z

#2552

moved these changes into the above PR

jkasten2 added 9 commits February 1, 2026 16:47

fix: inverse LogLevel logic for omitting

7d68d83

This was backwards causing ERROR to send everything

chore: clean up initializeOtelLogging

a9b833e

Simplified logic, cleaned up logging statements, and removed code comments that added no value.

chore: clean up parseLogLevel

f400646

Removed "old" format support, we never shipped that. Removed int format, we never shipped nor plan to change it. Removed "logLevel" field fallback, we will always just use "log_level"

fix: lower severity of main thread log

9a8954d

In the context of remote logging this is "info", to the app developer this is more of a warning, however this is something we will develop later.

fix: processUptime

8f9c305

Looks like this was broke in a large refactor in commit 76460ee

fix: account for otel missing class

05ca3c4

Classes Otel depends on will be missing on Android 7 and older devices, or if the app is heavily minified. Added specific handling for this as well as an outer catch on Throwable so we at least allow any existing crash handlers to run.

fix: crash on otel usage on Android 7 and older

1bf6a25

fix: catch Throwable on otel access

3c604c5

We don't want logging to be the root cause of an app crash.

fix: lower severity of IAM paused log

e41a735

jkasten2 requested a review from abdulraqeeb33 February 2, 2026 05:04

jkasten2 mentioned this pull request Feb 2, 2026

feat: tel crash reporting #2511

Open

18 tasks

jkasten2 changed the title ~~Otel logging misc fixes~~ fix: Otel logging misc fixes Feb 2, 2026

abdulraqeeb33 reviewed Feb 2, 2026

View reviewed changes

abdulraqeeb33 requested a review from Copilot February 2, 2026 15:59

Copilot started reviewing on behalf of abdulraqeeb33 February 2, 2026 15:59 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

jkasten2 added 4 commits February 8, 2026 20:56

fix: address Build.VERSION usage and tests

2656318

fix: default logging to NONE on parse error

b377734

fix: address log entries

f8e7b4a

fix: return NONE on paring error

dd14a15

jkasten2 requested a review from abdulraqeeb33 February 9, 2026 02:27

abdulraqeeb33 reviewed Feb 9, 2026

View reviewed changes

abdulraqeeb33 mentioned this pull request Feb 24, 2026

feat: logging_config-based remote logging control, SDK version gating, and misc Otel fixes #2552

Open

8 tasks

AR Abdul Azeez and others added 3 commits February 24, 2026 15:37

chore: remove CrashReportUploadTest

134a91c

Deleted in base branch by cleanup PR #2541. Co-authored-by: Cursor <cursoragent@cursor.com>

abdulraqeeb33 closed this Feb 24, 2026

abdulraqeeb33 deleted the otel-logging-misc-fixes branch February 24, 2026 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Otel logging misc fixes#2539

fix: Otel logging misc fixes#2539
jkasten2 wants to merge 16 commits intoar-otel-crash-reportingfrom
otel-logging-misc-fixes

jkasten2 commented Feb 2, 2026 •

edited by niels-s

Loading

Uh oh!

abdulraqeeb33 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abdulraqeeb33 Feb 9, 2026

Uh oh!

abdulraqeeb33 commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jkasten2 commented Feb 2, 2026 • edited by niels-s Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

One Line Summary

Details

Motivation

Scope

Testing

Unit testing

Manual testing

Affected code checklist

Checklist

Overview

Testing

Final pass

Uh oh!

abdulraqeeb33 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abdulraqeeb33 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

abdulraqeeb33 commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jkasten2 commented Feb 2, 2026 •

edited by niels-s

Loading