refactor(stack): drop Helm-ownership migration hacks#392
Closed
OisinKyne wants to merge 1 commit intooisin/377-2from
Closed
refactor(stack): drop Helm-ownership migration hacks#392OisinKyne wants to merge 1 commit intooisin/377-2from
OisinKyne wants to merge 1 commit intooisin/377-2from
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 9ef8cda commit added two pieces of compatibility ballast that
ran on every
obol stack up:migrateBaseHelmOwnership — labelled and annotated a hardcoded list
of pre-existing namespaces/RBAC objects to hand them to Helm.
The trigger was a one-off transition where prior obol versions
created those objects outside Helm; brittle (any new resource
needs another entry) and only exists to paper over a known dev-
machine state.
needsLiteLLMConfigHelmMigration / the conditional delete-and-
restore branch in preserveLiteLLMConfigForHelm — fired when the
litellm-config ConfigMap had a non-
helmfield manager(typically
kubectl-patchfrom oldobol model setupcalls).Current model.go patches use --field-manager=helm explicitly,
so the trigger is unreachable in the current code path.
Both fall under "code for a one-off issue that already passed".
What stays: preserveLiteLLMConfigForHelm (simplified to always
snapshot), restoreLiteLLMConfig, mergeLiteLLMConfig, and
ApplyServerSideForceConflicts. The base helmfile template only
includes the
paid/*catch-all route; without preserve+restore,every
obol stack upwould wipe user-added cloud providers andcustom endpoints. That's a real-resilience exception, not a hack.
Tests: TestNeedsLiteLLMConfigHelmMigration removed.
TestMergeLiteLLMConfigPreservesChartDefaultsAndPreviousModels stays.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com