Open
Conversation
nickh-obol
reviewed
Feb 12, 2026
pinebit
changed the title
KaloyanTanev
approved these changes
Feb 23, 2026
nickh-obol
reviewed
Feb 23, 2026
Comment on lines
94
to
97
| # Make OUTPUT_DIR absolute for docker bind mount | ||
| if [[ "$OUTPUT_DIR" != /* ]]; then | ||
| OUTPUT_DIR="$(pwd)/$OUTPUT_DIR" | ||
| fi |
Contributor
There was a problem hiding this comment.
This causes
mv: '/home/nick-obol/code/testing/node0c/./asdb-export/slashing-protection.json' and './asdb-export/slashing-protection.json' are the same file since $OUTPUT_FILE is relative but $OUTPUT_DIR is absolute. The comparison later on fails.
Suggested change
| # Make OUTPUT_DIR absolute for docker bind mount | |
| if [[ "$OUTPUT_DIR" != /* ]]; then | |
| OUTPUT_DIR="$(pwd)/$OUTPUT_DIR" | |
| fi | |
| # Make paths absolute for docker bind mount | |
| if [[ "$OUTPUT_FILE" != /* ]]; then | |
| OUTPUT_FILE="$(pwd)/$OUTPUT_FILE" | |
| fi | |
| OUTPUT_DIR=$(dirname "$OUTPUT_FILE") |
Contributor
Author
There was a problem hiding this comment.
Thank you, fixed as suggested
Comment on lines
+104
to
+113
| if ! docker compose run --rm -T \ | ||
| --entrypoint node \ | ||
| -v "$OUTPUT_DIR":/tmp/asdb-export \ | ||
| vc-lodestar /usr/app/packages/cli/bin/lodestar validator slashing-protection export \ | ||
| --file /tmp/asdb-export/slashing-protection.json \ | ||
| --dataDir /opt/data \ | ||
| --network "$NETWORK"; then | ||
| echo "Error: Failed to export slashing protection from vc-lodestar container" >&2 | ||
| exit 1 | ||
| fi |
Contributor
There was a problem hiding this comment.
This will create the slashing DB file owned as root, when the calling scripts try to run jq empty "$OUTPUT_FILE" it fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster Edit Scripts
script/edit/)scripts/edit/vc/)Testing
./scripts/edit/test/e2e_test.shthat runs complete E2E test using docker compose, by running real Lodestar VC, checking ASDB export/import and all edit commands in a sequence.