Fix build #92
Fix build #92
Conversation
| from pix2pixhd.options.test_options import TestOptions | ||
| from pix2pixhd.models.models import create_model | ||
| from pix2pixhd.data.base_dataset import BaseDataset, get_params, get_transform | ||
| from pix2pixhd.util.util import tensor2im |
There was a problem hiding this comment.
sry, forgot to update these – strange I did not notice via tests (I guess it must have been an old copy in my venv).
There was a problem hiding this comment.
CI shows the failure ...
|
If you think that pix2pixhd should be kept as a submodule, we could add it to ocrd_all instead of ocrd_anybaseocr. |
|
@bertsky, I updated the commit to fix only the build breakage. It no longer removes the pix2pixhd submodule. |
No, that would be a misfit – we only did this for modules which had broken dependencies (neither pip nor submodule workable). |
|
@kba (or whoever has the rights), please merge this pull request and update ocrd_all to get the fix. |
3 participants
Fixes: cbf2ca4 ("build with proper pix2pixhd pkg")
Signed-off-by: Stefan Weil sw@weilnetz.de