Skip to content

[18.0][FIX] queue_job: Fix TestJson #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrii9090-tecnativa wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+10 −2
Open

[18.0][FIX] queue_job: Fix TestJson #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions queue_job/tests/test_json_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ def test_encoder_recordset(self):
"su": False,
"context": expected_context,
}
self.assertEqual(json.loads(value_json), expected)
result_dict = json.loads(value_json)
for key in result_dict:
self.assertEqual(result_dict[key], expected[key])

def test_encoder_recordset_list(self):
demo_user = self.env.ref("base.user_demo")
Expand All @@ -52,7 +54,13 @@ def test_encoder_recordset_list(self):
"context": expected_context,
},
]
self.assertEqual(json.loads(value_json), expected)
result_dict = json.loads(value_json)
for result_value, expected_value in zip(result_dict, expected, strict=False):
if isinstance(expected_value, dict):
Copy link
Member

@pedrobaeza pedrobaeza Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this distinction. Just compare for equality of the dict at this level.

for key in result_value:
self.assertEqual(result_value[key], expected_value[key])
else:
self.assertEqual(result_value, expected_value)

def test_decoder_recordset(self):
demo_user = self.env.ref("base.user_demo")
Expand Down