[17.0][MIG] sale_margin_delivered: Migration to 17.0 by BhaveshHeliconia · Pull Request #239 · OCA/margin-analysis

BhaveshHeliconia · 2025-02-21T07:34:53Z

No description provided.

github-actions · 2025-11-30T12:42:35Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

…l on delivery purchase price [UPD] README.rst [UPD] Update sale_margin_delivered.pot Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

…not delivered qty (OCA#43) [FIX] sale_margin_delivered: Set % delivered percent to quantities ordered if the line has not delivered quantities [ADD] icon.png

…es (OCA#44)

…to compute delivered margin. Other module tests fails [UPD] README.rst

…s warning

…yer instead of stock move

… has not quantity delivered TT26105

…e to this Odoo commit OCA/OCB@8ca10a8

We don't want to compute margin based on stock moves for non storable products. This specially true for services and kits. TT33499

TT44910

…_margin_delivered_security

…ed_security TT44910

Currently translated at 100.0% (8 of 8 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/es/

- Include context keys for avoiding mail operations overhead.

Currently translated at 100.0% (8 of 8 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/it/

… sent than ordered

Currently translated at 100.0% (11 of 11 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/it/

…reality

…bility

'price_reduce' is deprecated and removed into the next version. Compute the prirce_reduct from the price_subotal / product_uom_qty. We might be tempted to use the 'price_reduce_taxecl' field from the sale order line but this field is rounded by default to the monetary precision. As an additional benefit this change ensures the compatibility with the 'sale_triple_discount' addon. Indeed, when 'sale_triple_discount' is installed, the discount field is not used as an aggregation of all the applied discount. It's only use to store the first discount applied. Therefore, the field is not properly computed since it doesn't include the second and third discount.

Put all the new fields after the orginal margin fields from odoo. (prior to this change, the new fields were displayed among the margin fields from Odoo

…ion of 1 As it's done into the sale_margin addon from odoo

Currently translated at 100.0% (11 of 11 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/it/

BhaveshHeliconia · 2025-12-02T05:10:09Z

Hey @OCA/accounting-maintainers would be great if someone could have a look at this module.

rrebollo

Please consider my suggestions, particularly those related to the OCA migration guidelines.

rrebollo · 2026-02-28T16:12:04Z

sale_margin_delivered/models/sale_margin.py

+    margin_delivered_percent = fields.Float(
+        compute="_compute_margin_delivered",
+        store=True,
+        readonly=True,


Suggested change

readonly=True,

Implicit when stored

rrebollo · 2026-03-01T00:55:56Z

sale_margin_delivered/tests/test_sale_margin_delivered.py

+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))


Suggested change

cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))

You are using BaseComon. The parent method has already executed this operation.

rrebollo · 2026-03-01T01:47:27Z

sale_margin_delivered/tests/test_sale_margin_delivered.py

+            self.env["stock.return.picking"].with_context(
+                active_ids=picking.ids,
+                active_id=picking.ids[0],
+                active_model="stock.picking",
+            )


From OCA Guidelines:

If you are using active_id, active_ids, or active_model in your view contexts (e.g., for a smart button), replace them with the recommended alternatives: - Use id instead of active_id - Use hard-coded model name instead of active_model

Question:
How does this affect the Form approach currently being used here?

rrebollo · 2026-03-01T01:50:54Z

sale_margin_delivered/views/sale_margin_delivered_view.xml

+                    name="margin_delivered_percent"
+                    string="Margin dlvd. (%)"
+                    optional="hide"
+                    attrs="{'invisible': [('price_subtotal', '=', 0)]}"


Suggested change

attrs="{'invisible': [('price_subtotal', '=', 0)]}"

invisible="not price_subtotal"

From OCA guidelines:

The XML attributes attrs and states are no longer used, and should be replaced by their equivalent Python expression under invisible, required and/or readonly attributes. Example: attrs="{'invisible': [('name', '=', 'red')]} is converted to invisible="name == 'red'". Full explanation and more examples at https://github.com/odoo/odoo/pull/104741. The module https://github.com/OCA/server-tools/tree/17.0/views_migration_17 can help to get a mostly-automatic transition.

BhaveshHeliconia mentioned this pull request Feb 21, 2025

Migration to version 17.0 #187

Open

10 tasks

BhaveshHeliconia force-pushed the 17.0-mig-sale_margin_delivered branch 3 times, most recently from effa715 to 01cccae Compare February 21, 2025 09:51

BhaveshHeliconia mentioned this pull request Feb 21, 2025

[17.0][MIG] sale_margin_delivered_dropshipping: Migration to 17.0 #240

Closed

BhaveshHeliconia force-pushed the 17.0-mig-sale_margin_delivered branch 2 times, most recently from 306b089 to 01cccae Compare May 9, 2025 09:53

BhaveshHeliconia force-pushed the 17.0-mig-sale_margin_delivered branch from 01cccae to e4e13bf Compare July 28, 2025 10:00

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 30, 2025

chienandalu and others added 20 commits December 2, 2025 10:00

[ADD] sale_margin_delivered: New Module

dd3c220

[IMP] sale_margin_delivered: Add new computed field for better contro…

84ed49d

…l on delivery purchase price [UPD] README.rst [UPD] Update sale_margin_delivered.pot Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[11.0][FIX] sale_margin_delivered: Set % delivered percent to 0.0 if …

99d5930

…not delivered qty (OCA#43) [FIX] sale_margin_delivered: Set % delivered percent to quantities ordered if the line has not delivered quantities [ADD] icon.png

[11.0][FIX] sale_margin_delivered: Fix cost price unit from stock mov…

5ca1b9d

…es (OCA#44)

[11.0][IMP] sale_margin_delivered: take an account returned moves

6bc147b

[11.0][IMP] sale_margin_delivered: Compute avoid use product_uom_qty …

45a65fd

…to compute delivered margin. Other module tests fails [UPD] README.rst

[IMP] stock_picking_comment_template: Change field label to fix travi…

cc4ed21

…s warning

[IMP] sale_margin_delivered: black, isort

5b1d7a7

[MIG] sale_margin_delivered: Migration to v13.0

ea95156

[FIX] sale_margin_delivered: Fix compute avco from stock valuation la…

fc7db8e

…yer instead of stock move

[FIX] sale_margin_delivered: Fix cache miss error.

34534cd

[FIX] sale_margin_delivered: Fix division by zero if no price_reduce

cd47d38

[FIX] sale_margin_delivered: Delivered values not zero when sale line…

1137112

… has not quantity delivered TT26105

[FIX] sale_margin_delivered: Use Form in tests to avoid crash test du…

62c7154

…e to this Odoo commit OCA/OCB@8ca10a8

[MIG] sale_margin_delivered: Migration to 15.0

8cc7cd6

[FIX] sale_margin_delivered: non storable

5dde111

We don't want to compute margin based on stock moves for non storable products. This specially true for services and kits. TT33499

[MIG] sale_margin_delivered: Migration to 16.0

5aeda53

TT44910

[REF] split sale_margin_delivered into sale_margin_delivered and sale…

7bd9143

…_margin_delivered_security

[OU-ADD] sale_margin_delivered: Script to install sale_margin_deliver…

e26f4f7

…ed_security TT44910

josep-tecnativa and others added 15 commits December 2, 2025 10:00

[IMP] sale_margin_delivered: test performance improvement

70ccba7

- Include context keys for avoiding mail operations overhead.

Added translation using Weblate (Italian)

fa6d5a8

[FIX] sale_margin_delivered: Fix calculation when more quantities are…

cbff335

… sent than ordered

[FIX] sale_margin_delivered: Margin Delivered (%) help doesn't match …

7a2c748

…reality

[REF] sale_margin_delivered: Preparate module to Dropshipping compati…

fe8825f

…bility

[FIX] sale_margin_delivered: Increase version due to multi commit on PR

451df4d

[IMP] sale_margin_delivered: Improve UI

4dcfa65

Put all the new fields after the orginal margin fields from odoo. (prior to this change, the new fields were displayed among the margin fields from Odoo

[IMP] sale_margin_delivered: Store margin delivered percent as a frat…

7efc740

…ion of 1 As it's done into the sale_margin addon from odoo

[FIX] sale_margin_analysis: Avoid ZeroDivisionError

50ed6ce

[IMP] sale_margin_delivered: pre-commit auto fixes

03562e3

[MIG] sale_margin_delivered: Migration to 17.0

e6a2d95

BhaveshHeliconia force-pushed the 17.0-mig-sale_margin_delivered branch from e4e13bf to e6a2d95 Compare December 2, 2025 04:30

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 7, 2025

Abranes approved these changes Feb 9, 2026

View reviewed changes

rrebollo mentioned this pull request Feb 28, 2026

[17.0] [MIG] sale_margin_delivered_security #257

Open

1 task

rrebollo suggested changes Mar 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[17.0][MIG] sale_margin_delivered: Migration to 17.0 #239

[17.0][MIG] sale_margin_delivered: Migration to 17.0 #239
BhaveshHeliconia wants to merge 35 commits intoOCA:17.0from
HeliconiaIO:17.0-mig-sale_margin_delivered

BhaveshHeliconia commented Feb 21, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

BhaveshHeliconia commented Dec 2, 2025

Uh oh!

rrebollo left a comment

Uh oh!

rrebollo Feb 28, 2026

Uh oh!

rrebollo Mar 1, 2026

Uh oh!

rrebollo Mar 1, 2026

Uh oh!

rrebollo Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

	attrs="{'invisible': [('price_subtotal', '=', 0)]}"
	invisible="not price_subtotal"

Uh oh!

Conversation

BhaveshHeliconia commented Feb 21, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

BhaveshHeliconia commented Dec 2, 2025

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

rrebollo Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

rrebollo Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

rrebollo Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

rrebollo Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants