[19.0][OU-ADD] crm: stage.team_id m2o→m2m promotion

[dnplkndll]

19.0 promotes crm.stage.team_id (m2o to crm.team) to team_ids (m2m). Without explicit migration the per-stage team assignment is lost (rendered as DEL old + NEW empty in the analysis). Since the new field has a different name, OpenUpgrade preserves the old column automatically — no pre-migration rename needed.

• post-migration.py — openupgrade.m2o_to_x2m() reads the preserved team_id column and populates crm_stage_crm_team_rel.
• No pre-migration (helper handles the full m2o → m2m promotion).

Test: asserts at least one stage has team_ids populated post-migration.

DEL fields on crm.lead (mobile, title) and res.users (target_sales_done, target_sales_won) left to database_cleanup per maintainer policy.

[pedrobaeza]

/ocabot migration crm

@dnplkndll Please avoid:

• Several commits for the same task.
• The commit message shouldn't include the version [19.0], and this is not [MIG], but adding a migration script. I use [OU-ADD] for that (on contrast by [OU-FIX] and [OU-IMP] for submitting patches or improvements over existing scripts) .

[remi-filament]

Thanks @dnplkndll for your PR

[remi-filament]

Comments should be just after concerned lines, marking the other ones as NOTHING TO DO

[dnplkndll]

Restructured in bea32d3 — per-group markers in the work doc. # DONE only next to the m2o→m2m promotion lines (event.question.event_id / event_type_id); other lines under # NOTHING TO DO.

[remi-filament]

You have an helper method on openupgradelib doing the same m2o_to_x2m()

I do not think that you need to rename the field beforehand anyhow since they do not have the same name it should be preserved by OpenUpgrade

[dnplkndll]

Done in bea32d3 — pre-migration removed entirely. Post-migration now uses openupgrade.m2o_to_x2m(env.cr, env['crm.stage'], 'crm_stage', 'team_ids', 'team_id') against the auto-preserved team_id column. Single 5-line function.

[dnplkndll]

@remi-filament — addressed both threads in bea32d3:

• Pre-migration removed entirely (column rename was unnecessary since new field name differs).
• Post-migration now uses openupgrade.m2o_to_x2m() helper — single call replaces the manual INSERT.
• Work-doc terseness applied throughout.

Title also tightened (crm: stage.team_id m2o→m2m promotion vs the prior vague Migration scripts). Fork CI green on both seeds. Ready for re-review.

[hbrunn]

the commit message does not describe what the code does. Generally, please tone down the chattiness of your bullshit generator by 100.

I don't think the tests are very helpful here, the first fails in some corner cases like no stages at all in the DB, the second tests openupgradelib standard functionality. For such simple cases, I'd suggest no tests at all.

And the commit message title doesn't need to describe details, it's just the whole of the migration for crm.