Skip to content

chore: bump NosCore.Packets to 20.0.3#14

Open
erwan-joly wants to merge 1 commit intomasterfrom
chore/bump-packets-20.0.2
Open

chore: bump NosCore.Packets to 20.0.3#14
erwan-joly wants to merge 1 commit intomasterfrom
chore/bump-packets-20.0.2

Conversation

@erwan-joly
Copy link
Copy Markdown
Contributor

@erwan-joly erwan-joly commented Apr 24, 2026

Summary

Picks up:

  • 20.0.1 — `NsTeSTPacket.LeadingBlank` defaults to `string.Empty` so the serialized wire emits the literal double-space vanosilla expects instead of `-`.
  • 20.0.2 — new `LeadingBlank` field on `AscrPacket` (same double-space pattern as NsTeST).

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Bumped the centrally managed NosCore.Packets package version to 20.0.3, ensuring the project uses the updated runtime/library across builds and deployments.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 697e2579-173a-4f72-87fa-b973c9a521b3

📥 Commits

Reviewing files that changed from the base of the PR and between b02fe1b and 5bf6609.

📒 Files selected for processing (1)
  • Directory.Packages.props
🚧 Files skipped from review as they are similar to previous changes (1)
  • Directory.Packages.props

📝 Walkthrough

Walkthrough

The centrally managed NuGet package version for NosCore.Packets in Directory.Packages.props is updated from 19.0.0 to 20.0.3.

Changes

Cohort / File(s) Summary
Package Version Update
Directory.Packages.props
Updated NosCore.Packets PackageVersion from 19.0.020.0.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 I hopped into props with a tiny cheer,
Nineteen became twenty — a version is near.
Packets refreshed, I twirl and I prance,
A rabbit's small dance for a one-line advance. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states version 20.0.3 but the objectives mention version 20.0.2 as the target, creating a discrepancy with the stated upstream changes. Clarify the actual target version: verify whether the bump is to 20.0.2 or 20.0.3, and ensure the PR title matches the actual implementation and objectives.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-packets-20.0.2

Comment @coderabbitai help to get the list of available commands and usage tips.

Picks up:
- 20.0.1 — NsTestPacket.LeadingBlank defaults to empty string.
- 20.0.2 — AscrPacket gains LeadingBlank field.
- 20.0.3 — PacketBase.IsValid accepts empty strings on non-nullable
  string fields so LeadingBlank=string.Empty no longer fails the
  Required-attribute check on send.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@erwan-joly erwan-joly force-pushed the chore/bump-packets-20.0.2 branch from b02fe1b to 5bf6609 Compare April 24, 2026 23:28
@erwan-joly erwan-joly changed the title chore: bump NosCore.Packets to 20.0.2 chore: bump NosCore.Packets to 20.0.3 Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant