Rework Electric Tools#28
Open
Exaxxion wants to merge 2 commits into
Open
Conversation
- Mitigate some potential sources of NullPointerExceptions - MV/HV tools no longer gain +1 harvest level - Electric tools no longer take more damage than the base tool: For example LV chainsaw took 8 damage instead of saw's 2 damage from crafting table use, reducing its nominal 10x durability to more like 2.5x for this purpose. The HV chainsaw took 128 damage for the same operation, reducing its nominal 40x durability to less than 1x. Similarly, damage from breaking blocks increased from 1 (LV) to 2 (MV) to 8 (HV), so the effective durability multipliers were 10x, 10x, 5x. Removing this damage scaling allows for less confusing results and clear benefits to higher tier tools. - Adjust for the above by setting durability for tiered electric tools to 5/10/20x, except drills (10/20/40x, as before) - Electric Wrench base attack damage is now 4/5/6 (was 3)
- Charging no longer prevents block breaking - Charging no longer causes the tool to trigger item re-equip animation Many thanks to @WaitingIdly and @ghzdude for their help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electric Tools as implemented by GTCE were a mess for a variety of reasons.
The durability was nominally increased with each tier of electric tool, but the amount of damage the tools took was also increased, making it hard to reason about the actual amount of durability.
For example, the LV chainsaw took 8 damage instead of a standard saw's 2 damage from crafting table use, reducing its nominal 10x durability to more like 2.5x for this purpose. The HV chainsaw took 128 damage for the same operation, reducing its nominal 40x durability to less than 1x.
Similarly, damage from breaking blocks increased from 1 (LV) to 2 (MV) to 8 (HV), so the effective durability multipliers were 10x, 10x, 5x.
Removing this damage scaling allows for less confusing results and clear benefits to higher tier tools.
Additionally, electric tools were impossible to use while charging, which made them really annoying to use. Some changes to the
MetaItemclass allow for preventing both the re-equip animation bobbing and interruption of ongoing block breaking.There was also an inexplicable gain of one additional harvest level when using MV and HV tools.
I have therefore rebalanced the electric tools as follows: