fix: add favicon.ico support#476
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds favicon support by configuring the Eleventy passthrough and adding the icon link to the main template. It also includes a layout adjustment for the developer list. Feedback suggests removing the hardcoded versioning from the favicon link and using standard Tailwind spacing classes instead of arbitrary values for the layout change, which should ideally be handled in a separate commit.
| <div class="p-8"> | ||
| <div class="flex justify-between items-start gap-4"> | ||
| <div class="flex-1"> | ||
| <div class="flex-1 min-w-[150px]"> |
There was a problem hiding this comment.
This layout change (min-w-[150px]) appears to be unrelated to the favicon support described in the PR title and description. To maintain code quality and follow the principle of atomic commits, unrelated changes should be handled in a separate pull request. Additionally, consider using standard Tailwind spacing classes (e.g., min-w-36 or min-w-40) instead of arbitrary values to ensure consistency with the design system.
<div class="flex-1">
References
- Adhere to the project's existing CSS framework (Tailwind CSS) and its conventions, such as using standard theme values for spacing and sizing instead of arbitrary values.
Fixes #134
Added favicon.ico support by:
favicon.icofileThis resolves the 404 issue for

/favicon.ico.