Rename fly_thumb_georef → fly_georef, add bearing-based auto rotation#27
Merged
NewGraphEnvironment merged 2 commits intomainfrom Mar 12, 2026
Merged
Rename fly_thumb_georef → fly_georef, add bearing-based auto rotation#27NewGraphEnvironment merged 2 commits intomainfrom
NewGraphEnvironment merged 2 commits intomainfrom
Conversation
- Rename fly_thumb_georef() to fly_georef() — works with any image, not just thumbnails (#24) - Add rotation param (0/90/180/270, default 180) to correct image orientation. Per-photo rotation via column on input sf (#25) - Add fly_bearing() to compute flight line bearing from consecutive centroids per roll — diagnostic tool for determining rotation - 102 tests passing Fixes #24 Fixes #25 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rotation="auto" (new default) computes flight bearing per-photo and derives GCP rotation via floor((bearing + 91) / 90) * 90 %% 360. Calibrated on 10 BC aerial photos (1968-2019), 8/10 correct. Diagonal flights (~45° off cardinal) are unreliable — override with rotation column. Add data-raw/test_georef_decades.R for visual QA across decades. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fly_thumb_georef()→fly_georef()— works with any image, not just thumbnails (Rename fly_thumb_georef to fly_georef #24)fly_bearing()— compute flight line bearing from consecutive centroids per rollrotationparam tofly_georef()with"auto"default — derives rotation from bearing via calibrated formulafloor((bearing + 91) / 90) * 90 %% 360rotationcolumn on input sfdata-raw/test_georef_decades.Rfor visual QA across decadesAuto rotation is correct for ~80% of photos (E-W flight lines). Diagonal flights (~45° off cardinal) are unreliable and need manual override — tracked in #26.
Fixes #24
Fixes #25
Relates to NewGraphEnvironment/sred-2025-2026#17
Test plan
data-raw/test_georef_decades.R) produces valid georefs🤖 Generated with Claude Code