Skip to content

Exclude --enable-manager from ComfyUI-Zluda inherited launch options#2

Open
Copilot wants to merge 5 commits intomainfrom
copilot/update-comfyui-zluda-launch-options
Open

Exclude --enable-manager from ComfyUI-Zluda inherited launch options#2
Copilot wants to merge 5 commits intomainfrom
copilot/update-comfyui-zluda-launch-options

Conversation

Copy link
Copy Markdown

Copilot AI commented May 2, 2026

ComfyZluda.LaunchOptions inherits all base ComfyUI launch options except "Cross Attention Method", which inadvertently included the "Enable Manager" (--enable-manager) option — irrelevant and undesirable for the ZLUDA variant.

Change

Extended the exclusion filter in ComfyZluda.LaunchOptions to also drop "Enable Manager":

// Before
options.AddRange(base.LaunchOptions.Where(x => x.Name != "Cross Attention Method"));

// After
options.AddRange(
    base.LaunchOptions.Where(x =>
        x.Name != "Cross Attention Method" && x.Name != "Enable Manager"
    )
);

All other inherited base options are unaffected.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • nuget-feed-nightly.avaloniaui.net
    • Triggering command: /usr/bin/dotnet dotnet build StabilityMatrix.Core/StabilityMatrix.Core.csproj -c Release --no-restore (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore StabilityMatrix.Core/StabilityMatrix.Core.csproj (dns block)
    • Triggering command: /usr/bin/dotnet dotnet build StabilityMatrix.Core/StabilityMatrix.Core.csproj -c Release (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Modify the ComfyUI-Zluda package so it does not inherit the --use-manager launch argument from the base ComfyUI package launch options.

Repository: NeuralFault/StabilityMatrix
Branch: main

Context:

  • The ComfyUI-Zluda package is implemented in StabilityMatrix.Core/Models/Packages/ComfyZluda.cs.
  • Currently, ComfyZluda.LaunchOptions builds a Zluda-specific list and then appends base.LaunchOptions except for the option named "Cross Attention Method".
  • This causes ComfyZluda to inherit all other ComfyUI launch options, including --use-manager.

Task:

  1. Update ComfyZluda.LaunchOptions so that it excludes the --use-manager option inherited from base.LaunchOptions.
    • Prefer filtering by the option Name if that is stable/known; otherwise filter by InitialValue/Options containing --use-manager.
    • Keep the existing behavior of excluding/replacing "Cross Attention Method".
  2. Ensure no other launch options are unintentionally removed.
  3. Add/adjust any unit tests if the repo has coverage for package launch options; otherwise keep changes minimal and compile-safe.

Acceptance criteria:

  • ComfyUI-Zluda no longer presents or uses the --use-manager launch argument from base ComfyUI launch options.
  • Other inherited options still appear as before.
  • Code builds successfully.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Does the comfyu-zluda package config inherit launch options from regular comfyui config, or does it set its own entirely (for example would it inherit --use-manager from regular comfyui.cs?)

Assistant: It inherits launch options from the regular ComfyUI package config, and then overrides/augments a small subset.

In ComfyZluda.cs, ComfyZluda inherits from ComfyUI:

  • public class ComfyZluda(...) : ComfyUI(...) (lines 27–35)

And its LaunchOptions override does this:

  • Creates its own ZLUDA-specific options list (lines 60–103)
  • Then adds the base ComfyUI launch options via:
options.AddRange(base.LaunchOptions.Where(x => x.Name != "Cross Attention Method"));

(lines 105–106)

So:

  • It keeps everything from base.LaunchOptions (i.e., from ComfyUI)
  • Except it replaces the base "Cross Attention Method" definition with its own ZLUDA-specific version.

Your example: --use-manager

If --use-manager is provided by ComfyUI’s LaunchOptions, then yes, ComfyUI-Zluda will also include it, because it pulls in base.LaunchOptions wholesale (minus only the "Cross Attention Method" entry).

If you want, paste the ComfyUI.cs link (or I can fetch it) and I’ll point to the exact --use-manager definition and confirm how it’s represented (name, default, etc.).

User: Need a modification that overrides the launch argument inherited from regular comfyui (--use-manager)

Assistant: I’ve kicked off the change, and I’m currently waiting on your confirmation from the approval dialog before I can proceed with applying the modification.

This pull request was created from Copilot chat.

Copilot AI changed the title [WIP] Update ComfyZluda launch options to exclude --use-manager Exclude --enable-manager from ComfyUI-Zluda inherited launch options May 2, 2026
Copilot AI requested a review from NeuralFault May 2, 2026 12:01
@NeuralFault NeuralFault marked this pull request as ready for review May 4, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants