fix: Incorrect P2PContext in bcast example

[emlautarom1]

The bcast example (https://github.com/NethermindEth/pluto/blob/c4c922a19c0efc29baf882d3ed438e4ccdc73f82/crates/dkg/examples/bcast.rs) is currently broken due to the usage of an incorrect P2PContext which results in active connections to known peers not getting updated, thus failing to broadcast despite the connections actually being active.

This PR implements the minimal fix required to sort out the issue, but some comments are included to avoid similar situations in the future.

[emlautarom1]

This handle approach is similar to what we have in parsigex: #291 (comment).

The design is very cumbersome to use so it requires some further work.

[iamquang95]

can you try to remove this and use the outer p2p_context, that will be cleaner without having the mut component

[emlautarom1]

We can, I was just following the patterns that we already have in bootnode and parsigex:

pluto/crates/p2p/examples/bootnode.rs

Lines 141 to 163 in 0de6cdc

	let mut node: Node<ExampleBehaviour> = Node::new(
	p2p_config,
	pk,
	NodeType::QUIC,
	false,
	known_peers.clone(),
	|builder, keypair, relay_client| {
	let p2p_context = builder.p2p_context();
	let local_peer_id = keypair.public().to_peer_id();
	// Create identify config
	let identify_config =
	identify::Config::new("/charon/1.0.0".to_string(), keypair.public());
	builder.with_gater(conn_gater).with_inner(ExampleBehaviour {
	relay: relay_client,
	relay_reservation: MutableRelayReservation::new(relays.clone()),
	relay_router: RelayRouter::new(relays.clone(), p2p_context, local_peer_id),
	identify: identify::Behaviour::new(identify_config),
	ping: ping::Behaviour::new(ping::Config::new()),
	})
	},
	)?;

pluto/crates/parsigex/examples/parsigex.rs

Lines 264 to 296 in 0de6cdc

	let mut parsigex_handle: Option<Handle> = None;
	let mut node: Node<CombinedBehaviour> = Node::new(
	p2p_config,
	key,
	NodeType::QUIC,
	args.filter_private_addrs,
	known_peers.clone(),
	|builder, keypair, relay_client| {
	let p2p_context = builder.p2p_context();
	let local_peer_id = keypair.public().to_peer_id();
	let config = parsigex::Config::new(
	local_peer_id,
	p2p_context.clone(),
	verifier.clone(),
	duty_gater.clone(),
	)
	.with_timeout(Duration::from_secs(10));
	let (parsigex, handle) = parsigex::Behaviour::new(config);
	parsigex_handle = Some(handle);
	builder
	.with_gater(conn_gater)
	.with_inner(CombinedBehaviour {
	parsigex,
	relay: relay_client,
	relay_reservation: MutableRelayReservation::new(relays.clone()),
	relay_router: RelayRouter::new(relays.clone(), p2p_context, local_peer_id),
	})
	},
	)?;
	let parsigex_handle =
	parsigex_handle.ok_or_else(|| anyhow!("parsigex handle should be created"))?;

[iamquang95]

Maybe we will revisit these examples to see if we can have a cleaner approach. LGTM now

[emlautarom1]

This set duplicates the information that P2PContext and its PeerStore already manage. ClusterInfo is in the same situation, where pretty much all information is duplicated in some way.