test(cli/mev): add integration tests for MEV test command by varex83agent · Pull Request #329 · NethermindEth/pluto

varex83agent · 2026-04-15T10:04:04Z

Summary

Follow-up to #300. Adds the integration tests missing from the initial MEV test implementation, as noted in the review thread.

default scenario: healthy mocked MEV node → Ping OK, PingMeasure Good, CreateBlock Skip
connection refused: two unreachable endpoints → Ping Fail, PingMeasure Fail, CreateBlock Skip with error messages
timeout: 100ns timeout → all network tests fail with timeout/interrupted verdict
quiet mode: --quiet produces no stdout output
unsupported test case: unknown test name returns "test case not supported" error
custom test cases: --test-cases=Ping runs only Ping per endpoint
write to file: --output-json produces valid JSON with mev key

Tests ported from testmev_internal_test.go. The default load scenario and flag-parsing tests are deferred to a further follow-up since they require a live beacon node or deeper CLI wiring.

Test plan

cargo test --package pluto-cli --bin pluto -- commands::test::mev::tests passes (9/9)
cargo clippy clean
cargo +nightly fmt clean
cargo deny check clean

🤖 Generated with Claude Code

- Follow the `test validator` approach (enum + impl block) - Simplify error handling for timeouts

- Test is already cancelled by caller appropriately

- Workaround for false positive

- Use tokio::time::Instant instead of std::time::Instant in async code - Replace CliError::Other string literals with typed variants TimeoutInterrupted and TestCaseNotSupported - Remove TestResultError from imports; use CliError::TimeoutInterrupted directly - Simplify latest_beacon_block and fetch_proposers_for_epoch to use ? operator, leveraging existing From impls on CliError - Simplify get_block_header error conversions with .map_err(MevError::from) and .map_err(|e| MevError::Cli(e.into())) Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

RUSTSEC-2026-0097: rand 0.8.x unsoundness (transitive dep) RUSTSEC-2026-0098: rustls-webpki URI name constraint bypass (transitive dep) Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

These features are absent from Charon v1.7.1: - Remove x-timeout-ms CLI flag and x_timeout_ms field from TestMevArgs - Remove X-Timeout-Ms and Date-Milliseconds headers from get_block_header - Remove credential parsing (parse_endpoint_credentials / apply_basic_auth) from mev_ping_test, latest_beacon_block, fetch_proposers_for_epoch, and get_block_header - Replace x_timeout_ms-based thresholds in mev_create_block_test with fixed 500ms/800ms constants matching Go reference thresholds Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

Resolve conflicts: - deny.toml: adopt main's detailed reason comment for RUSTSEC-2026-0097, keep RUSTSEC-2026-0098 - crates/cli/Cargo.toml: add chrono from main - crates/cli/src/commands/test/mod.rs: accept main's refactor (helpers/constants modules) - crates/cli/src/commands/test/mev.rs: update imports for helpers/constants split, use SLOTS_IN_EPOCH.get() for NonZero<u64> Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

Port tests from testmev_internal_test.go covering: - default scenario: healthy MEV node returns Ping OK, PingMeasure Good, CreateBlock Skip - connection refused: Ping and PingMeasure fail with error, CreateBlock skips - timeout: very short timeout causes Fail verdicts for network tests - quiet mode: no stdout output when quiet=true - unsupported test case: returns "test case not supported" error - custom test cases filter: only specified tests are run - write to file: output_json path produces valid JSON with mev key Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

rustls-webpki wildcard name constraint bypass — transitive dep, cannot upgrade immediately. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

mskrzypkows · 2026-04-23T14:18:23Z


    let latest_block_ts = std::time::UNIX_EPOCH
        .checked_add(Duration::from_secs(latest_block_ts_unix.unsigned_abs()))
        .unwrap_or(std::time::UNIX_EPOCH);


This can silently fail, would be better to return an error.

mskrzypkows · 2026-04-23T14:18:32Z

        .unwrap_or(std::time::UNIX_EPOCH);
    let next_block_ts = latest_block_ts
        .checked_add(SLOT_TIME)
        .unwrap_or(latest_block_ts);


mskrzypkows · 2026-04-23T14:20:54Z


    let mut next_slot = latest_slot.saturating_add(1);
    let slots_in_epoch_i64 = i64::try_from(SLOTS_IN_EPOCH.get()).unwrap_or(i64::MAX);
    let epoch = next_slot.checked_div(slots_in_epoch_i64).unwrap_or(0);


those two as well, why not return an error?

mskrzypkows · 2026-04-23T14:23:01Z

        }

        let elapsed = start_iteration.elapsed();
        let elapsed_nanos = u64::try_from(elapsed.as_nanos()).unwrap_or(u64::MAX);


mskrzypkows · 2026-04-23T14:23:13Z

    }

    let total_rtt: Duration = all_blocks_rtt.iter().sum();
    let count = u32::try_from(all_blocks_rtt.len().max(1)).unwrap_or(u32::MAX);


mskrzypkows · 2026-04-23T14:26:19Z

    loop {
        let start_iteration = Instant::now();
        let slots_in_epoch_i64 = i64::try_from(SLOTS_IN_EPOCH.get()).unwrap_or(i64::MAX);
        let epoch = next_slot.checked_div(slots_in_epoch_i64).unwrap_or(0);


mskrzypkows

LGTM, I would just change some unwraps to returning errors in case this code would be used in different context.

PoulavBhowmick03 and others added 16 commits March 28, 2026 13:09

feat: add mev cli tests

88601b6

clippy

1583cc9

Remove type aliases for test cases

e7f5fef

- Follow the `test validator` approach (enum + impl block) - Simplify error handling for timeouts

Use JoinSet

c65b0a2

Consistent argument ordering

5b4d55e

Remove select with CT

79dfc87

- Test is already cancelled by caller appropriately

Reorder parameters

dec0653

Remove redundant CancellationTokens

9706161

Pass main CT

9c690e3

Fix clippy lints

0c11a44

- Workaround for false positive

fix(deny): ignore RUSTSEC advisories for transitive deps

e961db0

RUSTSEC-2026-0097: rand 0.8.x unsoundness (transitive dep) RUSTSEC-2026-0098: rustls-webpki URI name constraint bypass (transitive dep) Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

fix(deny): ignore RUSTSEC-2026-0099 transitive dep advisory

ce5385c

rustls-webpki wildcard name constraint bypass — transitive dep, cannot upgrade immediately. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>

Base automatically changed from poulav/mev_test to main April 16, 2026 15:23

mskrzypkows reviewed Apr 23, 2026

View reviewed changes

mskrzypkows approved these changes Apr 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(cli/mev): add integration tests for MEV test command#329

test(cli/mev): add integration tests for MEV test command#329
varex83agent wants to merge 16 commits intomainfrom
feat/mev-tests

varex83agent commented Apr 15, 2026

Uh oh!

mskrzypkows Apr 23, 2026

Uh oh!

mskrzypkows Apr 23, 2026

Uh oh!

mskrzypkows Apr 23, 2026

Uh oh!

mskrzypkows Apr 23, 2026

Uh oh!

mskrzypkows Apr 23, 2026

Uh oh!

mskrzypkows Apr 23, 2026

Uh oh!

mskrzypkows left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

varex83agent commented Apr 15, 2026

Summary

Test plan

Uh oh!

mskrzypkows Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

mskrzypkows Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

mskrzypkows Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

mskrzypkows Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

mskrzypkows Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

mskrzypkows Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

mskrzypkows left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants