Fix indentation in tridentactionmirrorupdates k8s CRD YAML#1119
Open
JRuumis wants to merge 1 commit intoNetApp:masterfrom
Open
Fix indentation in tridentactionmirrorupdates k8s CRD YAML#1119JRuumis wants to merge 1 commit intoNetApp:masterfrom
JRuumis wants to merge 1 commit intoNetApp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
There is an extra space in the indentation of this YAML template:
https://github.com/NetApp/trident/blob/master/cli/k8s_client/yaml_factory.go#L2301-L2358
Technical Correction:
Project tracking
N/A
Do any added TODOs have an issue in the backlog?
No
Did you add unit tests? Why not?
No. This is a static template string correction, not a logic change.
Does this code need functional testing?
Yes. I locally verified that the generated YAML now passes strict parsing.
Is a code review walkthrough needed? why or why not?
No. The change is trivial.
Should additional test coverage be executed in addition to pre-merge?
No.
Does this code need a note in the changelog?
No. This fixes an underlying template formatting bug without altering expected user capabilities.
Does this code require documentation changes?
No. This fixes an underlying template formatting bug without altering expected user capabilities.
Additional Information
N/A