Skip to content

Fix indentation in tridentactionmirrorupdates k8s CRD YAML#1119

Open
JRuumis wants to merge 1 commit intoNetApp:masterfrom
JRuumis:fix-crd-indentation
Open

Fix indentation in tridentactionmirrorupdates k8s CRD YAML#1119
JRuumis wants to merge 1 commit intoNetApp:masterfrom
JRuumis:fix-crd-indentation

Conversation

@JRuumis
Copy link

@JRuumis JRuumis commented Mar 9, 2026

Change description

There is an extra space in the indentation of this YAML template:
https://github.com/NetApp/trident/blob/master/cli/k8s_client/yaml_factory.go#L2301-L2358

Technical Correction:

  • Issue: The entire block is offset by a single-space indentation, which violates YAML schema standards.
  • Proposed Change: Remove the leading space from each line in the linked range to restore proper structural alignment.
  • Impact: This ensures strict compliance with YAML parsers, consistency with other templates in yaml_factory and prevents validation failures in our environment.

Project tracking

N/A

Do any added TODOs have an issue in the backlog?

No

Did you add unit tests? Why not?

No. This is a static template string correction, not a logic change.

Does this code need functional testing?

Yes. I locally verified that the generated YAML now passes strict parsing.

Is a code review walkthrough needed? why or why not?

No. The change is trivial.

Should additional test coverage be executed in addition to pre-merge?

No.

Does this code need a note in the changelog?

No. This fixes an underlying template formatting bug without altering expected user capabilities.

Does this code require documentation changes?

No. This fixes an underlying template formatting bug without altering expected user capabilities.

Additional Information

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant