build(deps): bump msgpack from 1.1.2 to 1.2.1#1464
Conversation
Updates msgpack across all dependency surfaces (dependencies.yaml, conda recipes, generated conda envs, and pyproject.toml files). Fixes GHSA-6v7p-g79w-8964 (segfault in Unpacker after unpack failure) and the use-after-free in non-contiguous input handling. Closes #1451 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR bumps Changesmsgpack dependency bump
pre-commit exclude updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/cuopt-multi-objective-exploration/skill-card.md (1)
19-19: 🧹 Nitpick | 🔵 TrivialVerify NVSkills CI before merging this skills update.
skills/**changes must be validated with/nvskills-ci, and the bot’s signature commit must remain in the PR. As per path instructions, “PRs that change content underskills/must be validated by NVSkills CI with the/nvskills-cicomment before merge; the bot will push a signature commit that must remain in the PR.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/cuopt-multi-objective-exploration/skill-card.md` at line 19, This skills-card update needs NVSkills validation before merge; make sure the change under skills/** is checked with the /nvskills-ci command and keep the bot’s signature commit in the PR. Use the skill-card content update as the anchor, and ensure the review flow includes the required CI pass before merging.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@skills/cuopt-multi-objective-exploration/skill-card.md`:
- Line 19: This skills-card update needs NVSkills validation before merge; make
sure the change under skills/** is checked with the /nvskills-ci command and
keep the bot’s signature commit in the PR. Use the skill-card content update as
the anchor, and ensure the review flow includes the required CI pass before
merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 109e9b05-a13e-48e1-b9fd-9e4619cbef21
📒 Files selected for processing (10)
conda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-129_arch-x86_64.yamlconda/environments/all_cuda-133_arch-aarch64.yamlconda/environments/all_cuda-133_arch-x86_64.yamlconda/recipes/cuopt-server/recipe.yamlconda/recipes/cuopt-sh-client/recipe.yamldependencies.yamlpython/cuopt_self_hosted/pyproject.tomlpython/cuopt_server/pyproject.tomlskills/cuopt-multi-objective-exploration/skill-card.md
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.pre-commit-config.yaml:
- Around line 10-11: The trailing-whitespace hook exclusion is no longer aligned
with the existing special-case tree handling because the `helmchart` branch was
dropped from the regex while nearby hooks still exclude it. Update the
`trailing-whitespace` entry in `.pre-commit-config.yaml` to keep the `helmchart`
pattern alongside the existing datasets and skills exclusions, and preserve the
new markdown exclusions without removing the `helmchart` branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5fd41465-f27d-4030-b4bd-a9b0f6c0ce79
📒 Files selected for processing (1)
.pre-commit-config.yaml
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
b7647f4 to
9840e3f
Compare
…hook (#1465) NVSkills-Eval regenerates `skill-card.md` and `BENCHMARK.md` with trailing whitespace after `SKILL.md` changes; exclude them alongside `skill.oms.sig`.\n\nRelated: #1464 Authors: - Ramakrishna Prabhu (https://github.com/ramakrishnap-nv) Approvers: - James Lamb (https://github.com/jameslamb) URL: #1465
|
/merge |
Closes #1451
Summary
msgpack1.1.2 → 1.2.1 across all dependency surfaces:dependencies.yaml(single source of truth), generated conda environments (4 files), conda recipes (cuopt-server,cuopt-sh-client), and generatedpyproject.tomlfiles (cuopt_server,cuopt_self_hosted)Unpacker.unpack()after an unpacking failure (1.2.1)unpackb()/Unpacker.unpack()for non-contiguous input (1.2.0)The dependabot PR #1451 only updated
cuopt_self_hosted/pyproject.tomldirectly; this PR instead updatesdependencies.yamland runsrapids-dependency-file-generatorso all generated files stay in sync.🤖 Generated with Claude Code