Skip to content

build(deps): bump msgpack from 1.1.2 to 1.2.1#1464

Merged
rapids-bot[bot] merged 4 commits into
mainfrom
deps/bump-msgpack-1.2.1
Jun 26, 2026
Merged

build(deps): bump msgpack from 1.1.2 to 1.2.1#1464
rapids-bot[bot] merged 4 commits into
mainfrom
deps/bump-msgpack-1.2.1

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Closes #1451

Summary

  • Bumps msgpack 1.1.2 → 1.2.1 across all dependency surfaces: dependencies.yaml (single source of truth), generated conda environments (4 files), conda recipes (cuopt-server, cuopt-sh-client), and generated pyproject.toml files (cuopt_server, cuopt_self_hosted)
  • Fixes GHSA-6v7p-g79w-8964: segfault when calling Unpacker.unpack() after an unpacking failure (1.2.1)
  • Fixes use-after-free in unpackb()/Unpacker.unpack() for non-contiguous input (1.2.0)

The dependabot PR #1451 only updated cuopt_self_hosted/pyproject.toml directly; this PR instead updates dependencies.yaml and runs rapids-dependency-file-generator so all generated files stay in sync.

🤖 Generated with Claude Code

Updates msgpack across all dependency surfaces (dependencies.yaml,
conda recipes, generated conda envs, and pyproject.toml files).
Fixes GHSA-6v7p-g79w-8964 (segfault in Unpacker after unpack failure)
and the use-after-free in non-contiguous input handling.

Closes #1451

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv ramakrishnap-nv self-assigned this Jun 25, 2026
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 25, 2026
@ramakrishnap-nv ramakrishnap-nv marked this pull request as ready for review June 25, 2026 16:03
@ramakrishnap-nv ramakrishnap-nv requested a review from a team as a code owner June 25, 2026 16:03
@ramakrishnap-nv ramakrishnap-nv requested a review from msarahan June 25, 2026 16:03
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv ramakrishnap-nv requested a review from a team as a code owner June 25, 2026 17:09
@ramakrishnap-nv ramakrishnap-nv requested a review from tmckayus June 25, 2026 17:09
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b8d21d9c-3e4d-45a1-98b9-6b4b4fd885c2

📥 Commits

Reviewing files that changed from the base of the PR and between b7647f4 and 9840e3f.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .pre-commit-config.yaml

📝 Walkthrough

Walkthrough

The PR bumps msgpack and msgpack-python from 1.1.2 to 1.2.1 across Python project manifests, shared test dependencies, conda environments, and conda recipes. It also extends pre-commit exclusions for two markdown file patterns.

Changes

msgpack dependency bump

Layer / File(s) Summary
Python dependency pins
python/cuopt_self_hosted/pyproject.toml, python/cuopt_server/pyproject.toml, dependencies.yaml
msgpack and msgpack-python pins move from 1.1.2 to 1.2.1 in the Python project and shared test dependency manifests.
Conda environment and recipe pins
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-129_arch-x86_64.yaml, conda/environments/all_cuda-133_arch-aarch64.yaml, conda/environments/all_cuda-133_arch-x86_64.yaml, conda/recipes/cuopt-server/recipe.yaml, conda/recipes/cuopt-sh-client/recipe.yaml
msgpack-python pins move from 1.1.2 to 1.2.1 across the CUDA environment YAMLs and conda recipes.

pre-commit exclude updates

Layer / File(s) Summary
Hook exclusions
.pre-commit-config.yaml
The end-of-file-fixer and trailing-whitespace hook exclude patterns also cover skills/*/skill-card.md and skills/*/BENCHMARK.md.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • jameslamb
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The .pre-commit-config.yaml hook exclusions are unrelated to the msgpack bump and add scope beyond the linked issue. Remove the pre-commit hook exclusion changes or split them into a separate PR focused on repository hygiene.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: bumping msgpack from 1.1.2 to 1.2.1.
Description check ✅ Passed The description is on-topic and matches the dependency bump across the affected files.
Linked Issues check ✅ Passed The PR updates python/cuopt_self_hosted msgpack to 1.2.1 as requested and keeps the dependency refresh aligned.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/bump-msgpack-1.2.1

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
skills/cuopt-multi-objective-exploration/skill-card.md (1)

19-19: 🧹 Nitpick | 🔵 Trivial

Verify NVSkills CI before merging this skills update.

skills/** changes must be validated with /nvskills-ci, and the bot’s signature commit must remain in the PR. As per path instructions, “PRs that change content under skills/ must be validated by NVSkills CI with the /nvskills-ci comment before merge; the bot will push a signature commit that must remain in the PR.”

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/cuopt-multi-objective-exploration/skill-card.md` at line 19, This
skills-card update needs NVSkills validation before merge; make sure the change
under skills/** is checked with the /nvskills-ci command and keep the bot’s
signature commit in the PR. Use the skill-card content update as the anchor, and
ensure the review flow includes the required CI pass before merging.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@skills/cuopt-multi-objective-exploration/skill-card.md`:
- Line 19: This skills-card update needs NVSkills validation before merge; make
sure the change under skills/** is checked with the /nvskills-ci command and
keep the bot’s signature commit in the PR. Use the skill-card content update as
the anchor, and ensure the review flow includes the required CI pass before
merging.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 109e9b05-a13e-48e1-b9fd-9e4619cbef21

📥 Commits

Reviewing files that changed from the base of the PR and between fe8e976 and 81e0bf5.

📒 Files selected for processing (10)
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • conda/environments/all_cuda-133_arch-aarch64.yaml
  • conda/environments/all_cuda-133_arch-x86_64.yaml
  • conda/recipes/cuopt-server/recipe.yaml
  • conda/recipes/cuopt-sh-client/recipe.yaml
  • dependencies.yaml
  • python/cuopt_self_hosted/pyproject.toml
  • python/cuopt_server/pyproject.toml
  • skills/cuopt-multi-objective-exploration/skill-card.md

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.pre-commit-config.yaml:
- Around line 10-11: The trailing-whitespace hook exclusion is no longer aligned
with the existing special-case tree handling because the `helmchart` branch was
dropped from the regex while nearby hooks still exclude it. Update the
`trailing-whitespace` entry in `.pre-commit-config.yaml` to keep the `helmchart`
pattern alongside the existing datasets and skills exclusions, and preserve the
new markdown exclusions without removing the `helmchart` branch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5fd41465-f27d-4030-b4bd-a9b0f6c0ce79

📥 Commits

Reviewing files that changed from the base of the PR and between 81e0bf5 and b7647f4.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

Comment thread .pre-commit-config.yaml Outdated
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv ramakrishnap-nv force-pushed the deps/bump-msgpack-1.2.1 branch from b7647f4 to 9840e3f Compare June 25, 2026 19:23
@ramakrishnap-nv ramakrishnap-nv removed the request for review from msarahan June 25, 2026 19:27
rapids-bot Bot pushed a commit that referenced this pull request Jun 25, 2026
…hook (#1465)

NVSkills-Eval regenerates `skill-card.md` and `BENCHMARK.md` with trailing whitespace after `SKILL.md` changes; exclude them alongside `skill.oms.sig`.\n\nRelated: #1464

Authors:
  - Ramakrishna Prabhu (https://github.com/ramakrishnap-nv)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #1465
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot rapids-bot Bot merged commit 6a2ae8b into main Jun 26, 2026
179 of 181 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants