pathfinder: add sm_arch bitcode lookup#2231
Closed
aryanputta wants to merge 2 commits into
Closed
Conversation
Contributor
Contributor
|
There is already #2201. It's currently on hold, pending internal discussions. I'll close this PR. BTW: I started reviewing your #2196 but was too busy to finish the review. One high-level observation: it's a good start, but fixing up the Gen-AI-isms (e.g. over-explaining things that are not relevant beyond the scope of the PR) directly is far easier these days than crafting review comments. I'm still figuring out how to deal with that best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sm_archlookup tolocate_bitcode_lib()andfind_bitcode_lib()sm90,sm90a,sm_90, and90to the package filename suffixnvshmem_deviceaslibnvshmem_device_{sm_arch}.bcFixes #2200
Validation
python3 -m py_compile cuda/pathfinder/_static_libs/find_bitcode_lib.py tests/test_find_bitcode_lib.pygit diff --checkawk 'length($0) > 120 { print FILENAME ":" FNR ":" length($0) }' cuda_pathfinder/cuda/pathfinder/_static_libs/find_bitcode_lib.py cuda_pathfinder/tests/test_find_bitcode_lib.pypre-commit run ruff-check --files cuda_pathfinder/cuda/pathfinder/_static_libs/find_bitcode_lib.py cuda_pathfinder/tests/test_find_bitcode_lib.pypre-commit run ruff-format --files cuda_pathfinder/cuda/pathfinder/_static_libs/find_bitcode_lib.py cuda_pathfinder/tests/test_find_bitcode_lib.pygraphify update .python3 -m pytest tests/test_find_bitcode_lib.pyis blocked in this local macOS environment during collection before these tests run. Importingcuda.pathfinderselects the Linux dynamic-loader module and fails on missingdlinfofrom/usr/lib/libdl.dylib.