-
Notifications
You must be signed in to change notification settings - Fork 298
tests: Mark tests as unsafe or limit number of threads. #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c4b11c0
86629a4
6ee5f86
1f7783f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ def get_architecture_name(arch): | |
|
|
||
|
|
||
| @pytest.mark.skipif(sys.platform == "win32", reason="Test not supported on Windows") | ||
| @pytest.mark.thread_unsafe(reason="nvml init affects other threads") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Definitely true. |
||
| def test_init_ref_count(): | ||
| """ | ||
| Verifies that we can call NVML shutdown and init(2) multiple times, and that ref counting works | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -173,6 +173,7 @@ def test_find_binary_cache_negative_result(monkeypatch, mocker): | |
|
|
||
|
|
||
| @pytest.mark.usefixtures("clear_find_binary_cache") | ||
| @pytest.mark.thread_unsafe(reason="functools.cache may replace entry.") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This tests identity on |
||
| def test_caching_per_utility(): | ||
| """Verify that different utilities have independent cache entries.""" | ||
| nvdisasm1 = find_nvidia_binary_utility("nvdisasm") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This felt fine to me, as it writes the counter but if it doesn't seem good it could be an upstream issue. (CI ran into a segfault, IIRC.)