-
Notifications
You must be signed in to change notification settings - Fork 278
Add persistent program cache for Program.compile #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cpcloud
wants to merge
2
commits into
NVIDIA:main
Choose a base branch
from
cpcloud:persistent-program-cache-178
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from cuda.core._memoryview import ( | ||
| StridedMemoryView, | ||
| args_viewable_as_strided_memory, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "FileStreamProgramCache", | ||
| "InMemoryProgramCache", | ||
| "ProgramCacheResource", | ||
| "StridedMemoryView", | ||
| "args_viewable_as_strided_memory", | ||
| "make_program_cache_key", | ||
| ] | ||
|
|
||
| # Lazily expose the program-cache APIs so ``from cuda.core.utils import | ||
| # StridedMemoryView`` stays lightweight -- the cache backend pulls in driver, | ||
| # NVRTC, and module-load machinery that memoryview-only consumers do not need. | ||
| _LAZY_CACHE_ATTRS = frozenset( | ||
| { | ||
| "FileStreamProgramCache", | ||
| "InMemoryProgramCache", | ||
| "ProgramCacheResource", | ||
| "make_program_cache_key", | ||
| } | ||
| ) | ||
|
|
||
|
|
||
| def __getattr__(name): | ||
| if name in _LAZY_CACHE_ATTRS: | ||
| from cuda.core.utils import _program_cache | ||
|
|
||
| value = getattr(_program_cache, name) | ||
| globals()[name] = value # cache for subsequent accesses | ||
| return value | ||
| raise AttributeError(f"module 'cuda.core.utils' has no attribute {name!r}") | ||
|
|
||
|
|
||
| def __dir__(): | ||
| # Merge the lazy public API with the real module namespace so REPL and | ||
| # introspection tools still surface ``__file__``, ``__spec__``, etc. | ||
| return sorted(set(globals()) | set(__all__)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Persistent program cache for cuda.core. | ||
|
|
||
| Public surface: | ||
|
|
||
| * :class:`ProgramCacheResource` -- bytes-in / bytes-out ABC. | ||
| * :class:`InMemoryProgramCache` -- thread-safe LRU dict-backed cache. | ||
| * :class:`FileStreamProgramCache` -- atomic, multi-process directory cache. | ||
| * :func:`make_program_cache_key` -- key derivation for arbitrary | ||
| ``Program`` configurations. | ||
|
|
||
| The package is split into submodules by concern. Tests that need to | ||
| monkeypatch internals (Windows flag, version probes, helpers, ...) | ||
| should reach into the owning submodule (e.g. | ||
| ``_program_cache._file_stream._IS_WINDOWS``, | ||
| ``_program_cache._keys._linker_backend_and_version``) rather than the | ||
| package object: the symbols re-exported here are only convenience | ||
| aliases and don't intercept calls within the submodules. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from ._abc import ProgramCacheResource | ||
| from ._file_stream import FileStreamProgramCache | ||
| from ._in_memory import InMemoryProgramCache | ||
| from ._keys import make_program_cache_key | ||
|
|
||
| __all__ = [ | ||
| "FileStreamProgramCache", | ||
| "InMemoryProgramCache", | ||
| "ProgramCacheResource", | ||
| "make_program_cache_key", | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: I need to address this after 1.0 is out, xref: cupy/cupy#9801