Open
Conversation
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Contributor
Greptile SummarySystematically replaced generic assertions and error messages across 26 files with detailed, actionable error messages that include actual parameter values, expected values, shapes, dtypes, and device information. Major improvements:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 221d723 |
Signed-off-by: Przemek Tredak <ptredak@nvidia.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Przemyslaw Tredak <ptrendx@gmail.com>
for more information, see https://pre-commit.ci
Member
Author
|
/te-ci |
jberchtold-nvidia
approved these changes
Feb 25, 2026
Collaborator
jberchtold-nvidia
left a comment
There was a problem hiding this comment.
LGTM from the TE/JAX side! Thanks! I have not reviewed the core or PyTorch files
| assert FusedAttnFwdPrimitive.inner_primitive is not None | ||
| assert ( | ||
| FusedAttnFwdPrimitive.inner_primitive is not None | ||
| ), "FusedAttnFwdPrimitive.inner_primitive has not been registered" |
Collaborator
There was a problem hiding this comment.
nit SR: If you'd like, appending "This usually occurs when TransformerEngine was not installed properly and the shared library cannot be loaded. Please see the documentation troubleshooting for assistance" but as is it's already an improvement over no message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added better error messages throughout the codebase in order to provide more information when the error gets triggered.