feat(cli): add consent-gated runtime telemetry for NAT CLI commands#1897
Draft
yczhang-nv wants to merge 7 commits intoNVIDIA:developfrom
Draft
feat(cli): add consent-gated runtime telemetry for NAT CLI commands#1897yczhang-nv wants to merge 7 commits intoNVIDIA:developfrom
yczhang-nv wants to merge 7 commits intoNVIDIA:developfrom
Conversation
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
Signed-off-by: Yuchen Zhang <yuchenz@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Adds aggregate, anonymous CLI-usage telemetry to the
natPython CLI. Modeled on DataDesigner'stelemetry.pyand piggybacks on the existing NeMo Usage Telemetry project (clientId=184482118588404, schema 1.4 — companion MR inaire/microservices/nemo-telemetry).Posture is consent-gated, not default-on. A first-run prompt asks the user whether to allow telemetry; the decision is persisted. Non-interactive (CI / cron / piped) sessions never prompt and default OFF.
NAT_TELEMETRY_ENABLEDenv var overrides both.Consent flow
Order of precedence for whether telemetry is active:
NAT_TELEMETRY_ENABLEDenv var (any value —1/true/yesenables, anything else disables). Sets the answer for this shell session and bypasses the prompt.~/.config/nat/telemetry.toml(TOML, written once when the user answers the first-run prompt; can be re-set anytime vianat configure telemetry --enable | --disable).The persisted decision is at
~/.config/nat/telemetry.toml:CLI subcommand:
nat configure telemetryThree modes:
nat configure telemetry--enable — persist consent as enablednat configure telemetry--disable — persist consent as disablednat configure telemetry--status (default) — show current effective state and its sourceThe status command also flags when an env var is overriding the persisted decision, so users aren't surprised when their persisted choice doesn't take effect.
By Submitting this PR I confirm: