Skip to content

ignore the claude local setting#1184

Merged
kevalmorabia97 merged 2 commits intomainfrom
shengliangx/claude-local
Apr 7, 2026
Merged

ignore the claude local setting#1184
kevalmorabia97 merged 2 commits intomainfrom
shengliangx/claude-local

Conversation

@shengliangxu
Copy link
Copy Markdown
Collaborator

@shengliangxu shengliangxu commented Apr 6, 2026

as specified in https://code.claude.com/docs/en/settings#available-scopes

Summary by CodeRabbit

  • Chores
    • Updated repository ignore patterns for local configuration files.

as specified in https://code.claude.com/docs/en/settings#available-scopes

Signed-off-by: Shengliang Xu <shengliangx@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 67c38ef1-42cf-4356-ab38-2c27ab4e05ae

📥 Commits

Reviewing files that changed from the base of the PR and between c542c09 and d46df6e.

📒 Files selected for processing (1)
  • .gitignore

📝 Walkthrough

Walkthrough

The pull request adds a new ignore rule to the .gitignore file to exclude local Claude settings from version control. This prevents the .claude/settings.local.json file from being tracked by Git.

Changes

Cohort / File(s) Summary
Configuration
.gitignore
Added ignore pattern for .claude/settings.local.json to prevent local IDE settings from being committed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: adding a .gitignore rule for the local Claude settings file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Anti-Patterns ✅ Passed PR only modifies .gitignore and .claude/ directory files; no modelopt Python or dependency configuration changes present, making check not applicable and passing by default.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shengliangx/claude-local

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-07 03:27 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (1cceb95) to head (41ee908).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   74.77%   74.72%   -0.06%     
==========================================
  Files         351      351              
  Lines       40286    40286              
==========================================
- Hits        30125    30103      -22     
- Misses      10161    10183      +22     
Flag Coverage Δ
unit 54.81% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97 kevalmorabia97 merged commit 0d6fdd8 into main Apr 7, 2026
37 checks passed
@kevalmorabia97 kevalmorabia97 deleted the shengliangx/claude-local branch April 7, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants