Reorganise the prototype to use a central file for question data#70
Merged
Conversation
nataliariley
approved these changes
May 19, 2026
Collaborator
nataliariley
left a comment
There was a problem hiding this comment.
Looks great thanks Simon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the prototype (v4.1) to use YAML-based question content and a shared question renderer. This means there is a central place where all content can be managed.
A future piece of work may introduce a YAML-based rules file so that we can manage the logic in YAML rather than JavaScript.
View deployment: https://lung-health-check-pr-70.herokuapp.com/
Details of the changes:
app/prototype_v4_1/data/questions.yaml.app/prototype_v4_1/data/tobacco.yaml.app/prototype_v4_1/lib/questions.js.app/prototype_v4_1/lib/question-validator.js._question.htmlrenderer.eligibility.jsquestion-renderer.jssummary.jstobacco-flow.jsunit-navigation.jsquestion.jsso it mainly contains route handlers.