Skip to content

CCM-18337: Fix PDM Out Of Memory error #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonlabarere merged 4 commits into from
Jun 1, 2026
Merged

CCM-18337: Fix PDM Out Of Memory error #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c10dd2
CCM-18337: Suggestion from Copilot, added independent file to check m…
nhsd-angel-pastor May 20, 2026
c130b3f
Merge branch 'main' into feature/CCM-18337_oom_pdm
simonlabarere May 28, 2026
129306c
CCM-18337: Increase PDM Uploader memory
simonlabarere May 28, 2026
8e8a1e0
CCM-18337: Delete memory-comparison.js
simonlabarere May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infrastructure/terraform/components/dl/module_lambda_pdm_uploader.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module "pdm_uploader" {
function_include_common = true
handler_function_name = "handler"
runtime = "nodejs22.x"
memory = 256
memory = 512
timeout = var.lambda_timeout_seconds
log_level = var.log_level

Expand Down
12 changes: 7 additions & 5 deletions utils/utils/src/s3-utils/get-object-s3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { type Readable } from 'node:stream';
import { StringDecoder } from 'node:string_decoder';
import {
GetObjectCommand,
GetObjectCommandOutput,
Expand Down Expand Up @@ -36,12 +37,13 @@ export interface S3Location {

async function streamToString(Body: Readable) {
return new Promise<string>((resolve, reject) => {
const chunks: Buffer[] = [];
Body.on('data', (chunk: ArrayBuffer | SharedArrayBuffer) =>
chunks.push(Buffer.from(chunk)),
);
const decoder = new StringDecoder('utf8');
let result = '';
Body.on('data', (chunk: Buffer) => {
result += decoder.write(chunk);
});
Body.on('error', (err) => reject(err));
Body.on('end', () => resolve(Buffer.concat(chunks).toString('utf8')));
Body.on('end', () => resolve(result + decoder.end()));
});
}

Expand Down
Loading