CCM-17641: Reporting failures#335
Closed
nhsd-angel-pastor wants to merge 5 commits into
Closed
Conversation
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
11 times, most recently
from
ebb31fe to
1c5e70e
Compare
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
from
38abefa to
37ab511
Compare
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6 | ||
| with: | ||
| name: Integration test report | ||
| name: Integration test report${{ inputs.shard != '' && format(' ({0})', steps.shard_label.outputs.value) || '' }} |
Contributor
Author
There was a problem hiding this comment.
Taken for now from Ian's review to give the artifacts different name.
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
2 times, most recently
from
bb4f33d to
37ab511
Compare
| uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5 | ||
| - name: "Build docs" | ||
| uses: NHSDigital/nhs-notify-shared-modules/.github/actions/build-docs@3.0.0 | ||
| uses: NHSDigital/nhs-notify-shared-modules/.github/actions/build-docs@3.1.6 |
Contributor
Author
There was a problem hiding this comment.
Taken version that includes the build documentation fix from NHSDigital/nhs-notify-shared-modules#195.
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
from
37ab511 to
a6d499f
Compare
| $ref: ../defs/core.schema.yaml#/properties/failureCode | ||
| failureReason: | ||
| $ref: ../defs/core.schema.yaml#/properties/failureReason | ||
| reasonCode: |
nhsd-angel-pastor
force-pushed
the
feature/CCM-17641_reporting_failure
branch
from
a6d499f to
146b50b
Compare
…emas-status-published) is outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Taken from CCM-17639 the rename of the fields reasonCode and reasonText of the event DigitalLetterUnsuccessful.
Updated the report to send to trusts to use the reasonCode and reasonText for the event DigitalLetterUnsuccessful, which marks the communication type Digital as Failed.
Updated component test to reflect this.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.