CCM-15276: Update Core Notify Tests for Non Prod#320
CCM-15276: Update Core Notify Tests for Non Prod#320ScottFullerton-NHSE wants to merge 11 commits into
Conversation
nhsd-angel-pastor
left a comment
There was a problem hiding this comment.
I think there were some discussions for the component tests to decide whether all the tests should run or not in nonProd, but the tickets I found 15276, 15277 and 15278 seems about specific tests that don't work currently.
Maybe as I thought to implement "skipping the DLQ" tests in NonProd we could use an annotation from playwright as https://playwright.dev/docs/test-annotations#conditionally-skip-a-test ? But I don't know whether we want to try that as this ticket or different one though.
Skipping the DLQ check would speed up the component tests in nonprod by a decent margin, but if we aren't deploying to that environment that often, then I don't think having them run slightly longer is an issue. I did have to increase one of the component test timeouts by 2 minutes due to the DLQ check. |
gareth-allan
left a comment
There was a problem hiding this comment.
Looks good. A couple of comments, but nothing that's a must-have.
|
Have you run the tests in non-prod, by the way? |
083f2a8
Yeah, I had run them in nonprod before the most recent commit (added messageReference), and the tests were passing in that environment, and here in dev too. Going to run the tests against nonprod again now that we've added messageReference. |
Description
Fixed the following tests in nonprod:
Context
Allows us to run tests in non-prod without tests falling over.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.
Component Test Pipeline for Non Prod: https://github.com/NHSDigital/nhs-notify-internal/actions/runs/25490851901/job/74798818959