Skip to content

CCM-15276: Update Core Notify Tests for Non Prod#320

Open
ScottFullerton-NHSE wants to merge 11 commits into
mainfrom
feature/CCM-15276-update-core-notify
Open

CCM-15276: Update Core Notify Tests for Non Prod#320
ScottFullerton-NHSE wants to merge 11 commits into
mainfrom
feature/CCM-15276-update-core-notify

Conversation

@ScottFullerton-NHSE
Copy link
Copy Markdown
Contributor

@ScottFullerton-NHSE ScottFullerton-NHSE commented Apr 30, 2026

Description

Fixed the following tests in nonprod:

  • given PDMResourceAvailable event, when client has routingConfigId then a message is sent to core Notify
  • given PDMResourceAvailable event, when client does NOT exist then it goes to DLQ

Context

Allows us to run tests in non-prod without tests falling over.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Component Test Pipeline for Non Prod: https://github.com/NHSDigital/nhs-notify-internal/actions/runs/25490851901/job/74798818959

@ScottFullerton-NHSE ScottFullerton-NHSE requested a review from a team as a code owner April 30, 2026 08:35
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there were some discussions for the component tests to decide whether all the tests should run or not in nonProd, but the tickets I found 15276, 15277 and 15278 seems about specific tests that don't work currently.

Maybe as I thought to implement "skipping the DLQ" tests in NonProd we could use an annotation from playwright as https://playwright.dev/docs/test-annotations#conditionally-skip-a-test ? But I don't know whether we want to try that as this ticket or different one though.

@ScottFullerton-NHSE
Copy link
Copy Markdown
Contributor Author

I think there were some discussions for the component tests to decide whether all the tests should run or not in nonProd, but the tickets I found 15276, 15277 and 15278 seems about specific tests that don't work currently.

Maybe as I thought to implement "skipping the DLQ" tests in NonProd we could use an annotation from playwright as https://playwright.dev/docs/test-annotations#conditionally-skip-a-test ? But I don't know whether we want to try that as this ticket or different one though.

Skipping the DLQ check would speed up the component tests in nonprod by a decent margin, but if we aren't deploying to that environment that often, then I don't think having them run slightly longer is an issue. I did have to increase one of the component test timeouts by 2 minutes due to the DLQ check.

@gareth-allan gareth-allan self-assigned this May 12, 2026
gareth-allan
gareth-allan previously approved these changes May 12, 2026
Copy link
Copy Markdown
Contributor

@gareth-allan gareth-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of comments, but nothing that's a must-have.

Comment thread tests/playwright/constants/tests-constants.ts Outdated
@gareth-allan
Copy link
Copy Markdown
Contributor

Have you run the tests in non-prod, by the way?

@ScottFullerton-NHSE
Copy link
Copy Markdown
Contributor Author

Have you run the tests in non-prod, by the way?

Yeah, I had run them in nonprod before the most recent commit (added messageReference), and the tests were passing in that environment, and here in dev too.

Going to run the tests against nonprod again now that we've added messageReference.

@ScottFullerton-NHSE ScottFullerton-NHSE requested a review from a team as a code owner May 13, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants