PPHA-749: Changed fewer to less for decreased rolling tobacco journey#426
Open
PPHA-749: Changed fewer to less for decreased rolling tobacco journey#426
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the smoking history “changed amount/frequency” copy to use “less” (instead of “fewer”) specifically for decreased rolling tobacco journeys, aligning wording with prototype v1.4.
Changes:
- Renamed presenter helper from
more_or_fewertomore_or_fewer_or_less, returning"less"for decreased rolling tobacco and"fewer"for other decreased types. - Updated smoking frequency/amount form labels and required error messages to use the renamed presenter method.
- Updated unit tests and the end-to-end feature text to reflect the new wording.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
lung_cancer_screening/questions/presenters/tobacco_smoking_history_presenter.py |
Introduces the new “more/fewer/less” wording logic with rolling-tobacco-specific decreased handling. |
lung_cancer_screening/questions/forms/smoking_frequency_form.py |
Updates label/error-message copy to call the renamed presenter method. |
lung_cancer_screening/questions/forms/smoked_amount_form.py |
Updates label/error-message copy to call the renamed presenter method. |
lung_cancer_screening/questions/forms/smoking_change_form.py |
Adjusts decreased rolling-tobacco choice label to use “less than …” phrasing. |
lung_cancer_screening/questions/tests/unit/presenters/test_tobacco_smoking_history_presenter.py |
Updates presenter tests for the renamed method and expected wording. |
features/smoking_history.feature |
Updates cucumber steps to match the new UI text (“less” instead of “fewer”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lung_cancer_screening/questions/presenters/tobacco_smoking_history_presenter.py
Outdated
Show resolved
Hide resolved
lung_cancer_screening/questions/presenters/tobacco_smoking_history_presenter.py
Show resolved
Hide resolved
lung_cancer_screening/questions/tests/unit/presenters/test_tobacco_smoking_history_presenter.py
Outdated
Show resolved
Hide resolved
stephhou
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Why are we making this change?
To use the correct language as described in prototype v1.4