Skip to content

updated yml to show at test execution title with MNS validation flag#1378

Open
FimranNHS wants to merge 3 commits intomasterfrom
update--e2e-ymal-to-highlight-MNS-validation-is-required-or-not
Open

updated yml to show at test execution title with MNS validation flag#1378
FimranNHS wants to merge 3 commits intomasterfrom
update--e2e-ymal-to-highlight-MNS-validation-is-required-or-not

Conversation

@FimranNHS
Copy link
Copy Markdown
Contributor

@FimranNHS FimranNHS commented Apr 2, 2026

Summary

I’ve updated the e2e test‑automation YAML so the MNS validation flag is now visible directly in the test execution title.

We’ve also switched the mns_validation_required field back to a Boolean, with a default value of false.

For PR runs and internal dev executions, this flag will automatically be set to true.

For internal‑qa and int environments, the flag will remain false by default.

This follows the test‑scope agreement from ticket VED‑982 — since higher environments receive a large volume of data, enabling MNS validation there would cause unnecessary timeouts and false failures.
I also checked the local‑execution behaviour: if someone sets mns_validation_required to an empty string, None, or null in their local .env file, it still behaves correctly.

The only scenario where it would break is if someone tried to set:

os.environ["mns_validation_required"] = None - not possible

But OS‑level environment variables cannot be None, so this situation can’t occur in real usage.

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@avshetty1980
Copy link
Copy Markdown
Contributor

might want to change
setattr(ctx, var, os.getenv(var)) to setattr(ctx, var, os.getenv(var) or "false") in conftest.py so it does not crash if the env var is None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants