Feature/ndrs2 3696 sheffield brca#184
Merged
shilpigoeldev merged 10 commits intodevelopfrom Mar 20, 2026
Merged
Conversation
NImeson
previously approved these changes
Mar 20, 2026
Collaborator
NImeson
left a comment
NImeson
left a comment
There was a problem hiding this comment.
Logic all looks fine to me, happy that counts are now matching and no_scope cases are no longer appearing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I have made changes to Sheffield importer with new rules that were identified as part of new strings coming in new files.
Also we have updated MType for Sheffield. This resolves https://nhsd-jira.digital.nhs.uk/browse/NDRS2-3696.
Why?
New cases otherwise were being tagged as :no_scope.
How?
Fiona has added new rules.
Testing?
Tests have been added and now no case is marked as no scope.
Anything Else?
No