[GPCAPIM-278]: Deploy/redeploy a proxy instance for PRs#61
Open
davidhamill1-nhs wants to merge 45 commits intomainfrom
Open
[GPCAPIM-278]: Deploy/redeploy a proxy instance for PRs#61davidhamill1-nhs wants to merge 45 commits intomainfrom
davidhamill1-nhs wants to merge 45 commits intomainfrom
Conversation
davidhamill1-nhs
force-pushed
the
feature/GPCAPIM-278_automate_proxy_deployment_for_pr_envs
branch
from
684f11e to
742a78f
Compare
… of the proxy during from pipeline.
…eparation for dpeloying an instance of the proxy.
…iiting proxygen's yaml files
…t_for_pr_envs Signed-off-by: davidhamill1-nhs <109090521+davidhamill1-nhs@users.noreply.github.com>
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Image Scan SummaryImage: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:feature-gpcapim-278-automate-proxy-deployment-for-pr-envs
Findings (top 50)
|
…ned _status and _ping endpoints to confirm health of API.
…hin the API Platform; app-level0 uses apikey header. The later, the schema tests checks whether invalid API keys are rejected; the former, it does nothing with. As such, to attempting to handle a temporary auth flow for the sake of tests, we will move forward with app-level3.
…teps in to separate action.
…with which we can call the proxy
This reverts commit 03d5231.
… more easily be brought in to clinical-data-common.
|
|
Deployment Complete
|
davidhamill1-nhs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a new PR is created, an instance of the proxy is created in Apigee pointing to its preview env in AWS.
When a commit is pushed to remote, the instance is redeployed.
When the PR is closed, the proxy instance associate with it will be torn down.
Context
Consumers of CDG API will send their request through APIM's proxy in Apigee. In order to ensure behaviour is correctly developed and tested, instances of this proxy must be deployed during development to test a feature's changes.
Rather than do this manually, the preview environment workflow will deploy a PR-specific instance of the proxy; and handle the tear down when required.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.