Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new contract test suite to validate that the in-memory SDS FHIR stub conforms to the expected GET /Device and GET /Endpoint response contracts (including success, validation errors, routing via get(), and dynamic upsert/clear behaviour).
Changes:
- Added contract tests for SDS stub
GET /DeviceandGET /Endpoint(200 + 400 scenarios). - Added assertions around response headers/body structure (Bundle/OperationOutcome) and correlation-id echoing.
- Added coverage for the stub’s
get()routing and upsert/clear helper methods.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
Deployment Complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds contract tests for the SDS stub.
Context
The SDS stub needs to faithfully implement the /Device and /Endpoint endpoints for the SDS service. We need tests to verify that this is the case and that any changes made don't break the fidelity of the interface.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.