Skip to content

GPCAPIM-196 - alpha integration environment#149

Merged
neil-sproston merged 1 commit intomainfrom
GPCAPIM-196alphaInt
Apr 2, 2026
Merged

GPCAPIM-196 - alpha integration environment#149
neil-sproston merged 1 commit intomainfrom
GPCAPIM-196alphaInt

Conversation

@williamjameswillis
Copy link
Copy Markdown
Contributor

@williamjameswillis williamjameswillis commented Apr 1, 2026

  • Understand the issue: PROXY_BASE_PATH used under set -u without a guard in scripts/tests/run-test.sh
  • Add explicit check with clear error message before PROXY_BASE_PATH is used in the remote non-unit test branch

@neil-sproston neil-sproston marked this pull request as ready for review April 2, 2026 13:55
@neil-sproston neil-sproston requested review from a team as code owners April 2, 2026 13:55
Copilot AI review requested due to automatic review settings April 2, 2026 13:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for running non-unit test suites against an “alpha integration” APIM proxy instance by parameterizing the proxy base path used during remote test execution.

Changes:

  • Update the test runner to build --proxy-name using a new PROXY_BASE_PATH environment variable for remote, non-unit tests.
  • Wire PROXY_BASE_PATH into the preview environment workflow test steps (contract/schema/integration/acceptance).
  • Wire PROXY_BASE_PATH into the alpha-integration environment workflow test steps and adjust alpha-integration env configuration (e.g., ALB rule priority).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
scripts/tests/run-test.sh Switches remote proxy naming to be based on PROXY_BASE_PATH and adds extra branch logging.
.github/workflows/preview-env.yml Exports PROXY_BASE_PATH for remote non-unit test steps in preview environments.
.github/workflows/alpha-integration-env.yml Adds PROXY_BASE_PATH exports for alpha integration remote tests and updates env settings for the alpha integration deployment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Deployment Complete

@neil-sproston neil-sproston merged commit a97af3f into main Apr 2, 2026
53 checks passed
@neil-sproston neil-sproston deleted the GPCAPIM-196alphaInt branch April 2, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants