Skip to content

Update plugins to work with new python versions#428

Merged
afeefghannam89 merged 51 commits intomainfrom
feature/plugin-python-update
Mar 25, 2026
Merged

Update plugins to work with new python versions#428
afeefghannam89 merged 51 commits intomainfrom
feature/plugin-python-update

Conversation

@afeefghannam89
Copy link
Copy Markdown
Member

@afeefghannam89 afeefghannam89 commented Mar 18, 2026

  • Fix the pipeline start. There is a historical failure in all pipelines, except molecule_full_stack, which does not let them start, as planned. The branches parameter under pull_request event means the name of target branch not the feature branch name see the docs. A fix for another workflows will come in later PR see issue
  • Add Ansible sanity test using different Python and Ansible versions
  • Update python version to aktuell one
  • Pining the Ansible version im tests
  • Update cryptography Versions
  • Merge test_elasticsearch_modules.yml in the test_plugins.yml. They are testing the functionality of the modules in this collection, no need to have such separation.
  • Add verify tasks to test the functionality of elasticsearch_user and elasticsearch_role modules.
  • Fix syntax error from sanity tests e.g correct handling of imported libraries in the modules, comparing in if condition, long lines, missing types in argument_spec, extra spaces etc.
  • Replace the deprecated basic._ANSIBLE_ARGS with basic._load_params
  • Don't require password or role when deleting Elasticsearch user
  • Add dokumentation for the modules
  • Fix [Feature]: Update Plugins to python 3.11/12/13 #425

Copy link
Copy Markdown
Contributor

@Wintermute2k6 Wintermute2k6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 150 a valid value ? I'm not sure so I wanted to ask :)

Copy link
Copy Markdown
Contributor

@Wintermute2k6 Wintermute2k6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay

Copy link
Copy Markdown
Contributor

@Wintermute2k6 Wintermute2k6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 150 is a valid value I will approve it

Copy link
Copy Markdown
Contributor

@Wintermute2k6 Wintermute2k6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the Shebang/language should improve and directly use the language when using the script .. so the interpreter would not automatically choosen.

@afeefghannam89
Copy link
Copy Markdown
Member Author

Is 150 a valid value ? I'm not sure so I wanted to ask :)

Which 150, where?

@afeefghannam89
Copy link
Copy Markdown
Member Author

I thought the Shebang/language should improve and directly use the language when using the script .. so the interpreter would not automatically choosen.

under module_utils there is usually python code (e.g. class) which can be called over and over for example from modules. This code will not be executed but only called, that is why sanity sees shebang under module_utils as an error

@Wintermute2k6
Copy link
Copy Markdown
Contributor

Is 150 a valid value ? I'm not sure so I wanted to ask :)

Which 150, where?

I think here
72a58a5#diff-ae6b8d546f9acc3f885270435d4aa73880244a69e5b1f085af235b3ed5cc3966

@Wintermute2k6
Copy link
Copy Markdown
Contributor

I thought the Shebang/language should improve and directly use the language when using the script .. so the interpreter would not automatically choosen.

under module_utils there is usually python code (e.g. class) which can be called over and over for example from modules. This code will not be executed but only called, that is why sanity sees shebang under module_utils as an error

okay , then it makes sense to remove the shebang stuff.

@afeefghannam89
Copy link
Copy Markdown
Member Author

Is 150 a valid value ? I'm not sure so I wanted to ask :)

Which 150, where?

I think here 72a58a5#diff-ae6b8d546f9acc3f885270435d4aa73880244a69e5b1f085af235b3ed5cc3966

The file is removed. Sanity doesn't use this file like pep8

Wintermute2k6
Wintermute2k6 previously approved these changes Mar 25, 2026
widhalmt
widhalmt previously approved these changes Mar 25, 2026
Comment thread .github/workflows/test_plugins.yml
Comment thread molecule/plugins/verify.yml Outdated
afeefghannam89 and others added 2 commits March 25, 2026 14:18
Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>
Add clarification to a variable usage

Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>
@afeefghannam89 afeefghannam89 dismissed stale reviews from widhalmt and Wintermute2k6 via 83d7844 March 25, 2026 13:19
Copy link
Copy Markdown
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. :-)

@afeefghannam89 afeefghannam89 added this pull request to the merge queue Mar 25, 2026
@afeefghannam89 afeefghannam89 removed this pull request from the merge queue due to a manual request Mar 25, 2026
@afeefghannam89 afeefghannam89 merged commit e76ccb9 into main Mar 25, 2026
23 checks passed
@afeefghannam89 afeefghannam89 deleted the feature/plugin-python-update branch March 25, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Update Plugins to python 3.11/12/13

3 participants