PTHMINT-117: terminals and terminal-groups APIs and tests#56
Open
zulquer wants to merge 3 commits into
Open
Conversation
Introduce Terminal and TerminalGroup API surface: TerminalManager and TerminalGroupManager, request/response models (CreateTerminalRequest, Terminal), and listing/creation flows. Expose new SDK getters (get_terminal_manager, get_terminal_group_manager). Add example scripts for creating and listing terminals and listing terminals by group, plus dedicated example E2E fixtures that selectively skip tests when required env vars are missing. Include comprehensive unit and E2E tests covering serialization, option filtering, auth scopes, endpoint URLs, and response mapping. Also adjust shared e2e conftest validation signature to accept env name for clearer error messages.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 92.83% 92.96% +0.12%
==========================================
Files 164 172 +8
Lines 2889 3026 +137
==========================================
+ Hits 2682 2813 +131
- Misses 207 213 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add a pytest_collection_modifyitems hook in tests/multisafepay/e2e/conftest.py to skip all E2E tests when the E2E_API_KEY environment variable is not set, avoiding hard errors from real API calls during fixture setup. Also introduce EXAMPLE_E2E_NODE_PREFIX in tests/multisafepay/e2e/examples/conftest.py and restrict the example conftest's collection logic to only operate on example E2E tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive implementation for POS terminal and terminal group management in the SDK, along with example scripts and supporting models. The changes include new managers, request and response models, and integration into the main SDK interface.
SDK Feature Additions:
TerminalManagerandTerminalGroupManagerclasses to provide API operations for POS terminals and terminal groups, including listing and creation endpoints. [1] [2] [3] [4]Sdkclass, exposingget_terminal_managerandget_terminal_group_managermethods for easy access. [1] [2]Request and Response Models:
CreateTerminalRequestfor creating POS terminals, with validation for allowed providers and builder-style methods for setting attributes. [1] [2]Terminalresponse model to represent terminal data returned by the API, including a static method for instantiation from dictionaries. [1] [2]Examples and Usage:
Other Improvements:
_validate_e2e_base_urlnow takes the environment variable name for clearer error messages.