feat: remove mode argument from Semble#119
Open
stephantul wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the mode argument from the search. The mode just led to weaker results because it disabled the ranking pipeline. Because we also expose alpha, users can safely choose full bm25 or full semantic by setting alpha to 0.0 or 1.0, and still get the benefits of the ranking pipeline.
For ablations, I opted to remove the model results as well, I think the results are still pretty clear and actionable, although I can see the value in patching it for evaluation purposes (e.g., maybe disabling the reranking with a private boolean?)