chore(config): ignore local mcp.json and add example template#39
Closed
Code-MonkeyZhang wants to merge 6 commits intoMiniMax-AI:mainfrom
Closed
chore(config): ignore local mcp.json and add example template#39Code-MonkeyZhang wants to merge 6 commits intoMiniMax-AI:mainfrom
Code-MonkeyZhang wants to merge 6 commits intoMiniMax-AI:mainfrom
Conversation
Collaborator
|
Thanks for your PR! I've already implemented this feature based on your idea with some improvements:
See commit: a6e4334 Really appreciate your contribution! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR makes mcp.json a user-local configuration file and provides a committed template for reference.
Why
mcp.json can contain user-specific MCP server settings and API keys. Keeping it in the repo risks leaking secrets and makes local customization harder. A tracked example file plus a gitignored real config is a safer, clearer workflow.
What changed
scripts/setup-config.sh&scripts/setup-config.ps1examples/04_full_agent.pytests/test_mcp.pytests/test_integration.pyREADME.mdREADME_CN.mdmini_agent/config/config-example.yamlHow to use MCP now
Copy
mini_agent/config/mcp-example.jsontomini_agent/config/mcp.json, edit it to enable servers and add keys. Ifmcp.jsonis missing, Mini Agent still runs but without MCP tools.Testing
All test passed