Switch to double quotes for escaping

[Wikiwix]

When the extension runs in Windows, for cli commands CMD is used. CMD does not treat single quotes as a special character which causes problems

[MichaelCurrin]

Oh thanks for the PR and details

[MichaelCurrin]

I've published the change, let me know if it works for you

[Wikiwix]

The new version works on Windows :)

Thanks for the quick merge!

Something that I thought of in the meantime:
IMHO, ideally the command should not be called via a shell at all (instead running the command with a real array of arguments). With that setup, no quoting should get in the way, regardless of the operating system.
Looking at the used exec function though, I do not see a variant with this format (I do see one for execFile and spawn)…

[MichaelCurrin]

I tried execa package and that seems to work well for this specific case, but has other issues

#115

[MichaelCurrin]

This is the only flag in cli.ts that has quotes so I don't think it's worth changing how the app compiles just for that.

Plus, removing the quotes in string might work too for Windows + Unix. But if it's working now as is, I'll not tinker more with removing quotes.

[Wikiwix]

@MichaelCurrin I thought about removing quotes altogether too, and decided against it, because = is a special character in sh too (not under all circumstances, but I wanted to be on the safe side)

And I do agree, that keeping it as is, until another issue manifests is the reasonable thing to do :)

I added a comment on the implementation in #115 regarding what I was aiming for with the call without the use of a shell :)