Add feedback component.#2852
Open
bgravenorst wants to merge 13 commits intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore-all |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
alexandratran
left a comment
alexandratran
left a comment
There was a problem hiding this comment.
Looks good! However, it currently doesn't work on mobile for me.
Also, minor nits:
- It would look better to fully left-align the component on the quickstart pages:
- In dark mode, the button text would be more readable if it was black:
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
bgravenorst
force-pushed
the
add-feedback-widget
branch
from
30b36d4 to
b63827d
Compare
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Made-with: Cursor
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b86c68d. Configure here.
| .textarea:focus { | ||
| outline: none; | ||
| border-color: var(--ifm-color-primary) !important; | ||
| } |
There was a problem hiding this comment.
Unused .textarea CSS class in FeedbackWidget styles
Low Severity
The .textarea, .textarea::placeholder, and .textarea:focus CSS classes are defined but never referenced anywhere in the FeedbackWidget component. The component only uses .inlineTextarea for its textarea element. A grep for styles.textarea in the component returned zero matches, confirming this is dead CSS code that adds maintenance burden.
Reviewed by Cursor Bugbot for commit b86c68d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add feedback component.
Checklist
Note
Medium Risk
Adds a new serverless API that accepts user input and writes to Google Sheets using service-account credentials, which introduces new external I/O and environment-secret handling. UI placement changes are localized but the endpoint/validation and deployment wiring are the main risk areas.
Overview
Adds a new in-page feedback collection flow: a
FeedbackWidgetUI is introduced and embedded into doc footers, MDX pages, and the Quickstart page to capture yes/no ratings plus an optional/required comment.Introduces a new
/api/docs-feedbackVercel function that validates/sanitizes submissions (page URL allowlist, reason required for negative feedback, truncation) and appends them to a Google Sheet (timestamp, URL, rating, reason, device type) usingGOOGLE_SHEETS_CREDENTIALS/GOOGLE_SHEET_ID.Updates build/config/deps to support this: adds Google Sheets/auth and Vercel runtime packages, pins TypeScript, and adds a Docusaurus webpack rule using
null-loaderto preventapi/*.tsfrom being bundled into the site build.Reviewed by Cursor Bugbot for commit c822f5e. Bugbot is set up for automated code reviews on this repo. Configure here.