feat(account-tree-controller): add :accountGroup{Created,Updated}#8766
Open
ccharly wants to merge 2 commits into
Open
feat(account-tree-controller): add :accountGroup{Created,Updated}#8766ccharly wants to merge 2 commits into
:accountGroup{Created,Updated}#8766ccharly wants to merge 2 commits into
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adding more events that the
SnapAccountServicewill use.References
N/A
Checklist
Note
Medium Risk
Adds new messenger events and publishing logic in account add/remove and metadata mutation paths, which could affect downstream consumers that react to controller events. Core state shape is unchanged, but event timing/volume changes need verification.
Overview
Adds two new
AccountTreeControllermessenger events::accountGroupCreated(when a new group is created after init) and:accountGroupUpdated(when an existing group’s membership or metadata changes).Updates account insertion/removal flows to track which groups were created vs updated and publish the new events after the existing
:accountTreeChangeemission; group metadata setters (setAccountGroupName,setAccountGroupPinned,setAccountGroupHidden) now also emit:accountGroupUpdated. Test coverage is expanded to assert correct emission behavior (including no emission duringinit) andtypes/exports/changelog are updated accordingly.Reviewed by Cursor Bugbot for commit b08a6f4. Bugbot is set up for automated code reviews on this repo. Configure here.