Skip to content

feat(social-controllers): add followingProfileIds to controller state#8459

Merged
zone-live merged 3 commits intomainfrom
TSA-401-follow-state-profile-ids
Apr 15, 2026
Merged

feat(social-controllers): add followingProfileIds to controller state#8459
zone-live merged 3 commits intomainfrom
TSA-401-follow-state-profile-ids

Conversation

@Bigshmow
Copy link
Copy Markdown
Contributor

@Bigshmow Bigshmow commented Apr 15, 2026

Explanation

Adding followingProfileIds to controller state.

Stores Clicker profile IDs alongside existing followingAddresses on follow, unfollow, and updateFollowing. This enables the mobile UI to check follow status by trader profile ID without an extra API call.

TSA-401

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Adds a new persisted state field and updates follow/unfollow/updateFollowing mutations, which could affect consumers that assume the previous state shape or rely on persistence/migrations.

Overview
Adds followingProfileIds to SocialControllerState and persists it alongside followingAddresses so clients can track follows by Clicker profile ID.

Updates getDefaultSocialControllerState and controller metadata, and extends followTrader, unfollowTrader, and updateFollowing to populate/dedupe/remove/replace profile IDs in lockstep with addresses; tests and the package changelog are updated accordingly.

Reviewed by Cursor Bugbot for commit 38e27b9. Bugbot is set up for automated code reviews on this repo. Configure here.

@Bigshmow Bigshmow marked this pull request as ready for review April 15, 2026 01:29
@Bigshmow Bigshmow requested review from a team as code owners April 15, 2026 01:29
Comment thread packages/social-controllers/CHANGELOG.md Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 52d3647. Configure here.

Comment thread packages/social-controllers/src/SocialController.ts
@zone-live zone-live enabled auto-merge April 15, 2026 09:11
@zone-live zone-live added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 32d78e3 Apr 15, 2026
345 checks passed
@zone-live zone-live deleted the TSA-401-follow-state-profile-ids branch April 15, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants