fix(ramps): Fix addPrecreatedOrder's provider id format for legacy prefixed provider ids#8289
Open
fix(ramps): Fix addPrecreatedOrder's provider id format for legacy prefixed provider ids#8289
Conversation
…efixed provider ids
Member
Author
|
@metamaskbot publish-previews |
1 similar comment
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Draft
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Low risk: small normalization change to how
addPrecreatedOrderformatsprovider.id, plus a corresponding test/changelog update; main risk is minor compatibility impact for consumers expecting the old unprefixed id.Overview
addPrecreatedOrdernow normalizes incomingproviderCode(accepting legacy/providers/-prefixed values) and always writes stub orders withprovider.idin the canonical/providers/{code}format so they match ids used during polling.Updates the related unit test expectation and documents the fix in the
ramps-controllerchangelog.Written by Cursor Bugbot for commit 2d89a26. This will update automatically on new commits. Configure here.