feat: migrate awaitDeleteDelegationEntry to DelegationController#8286
Open
GuillaumeRx wants to merge 6 commits intomainfrom
Open
feat: migrate awaitDeleteDelegationEntry to DelegationController#8286GuillaumeRx wants to merge 6 commits intomainfrom
awaitDeleteDelegationEntry to DelegationController#8286GuillaumeRx wants to merge 6 commits intomainfrom
Conversation
6282ae6 to
1af8a27
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
This migrates the
awaitDeleteDelegationEntryfunction that was defined on the clients side toDelegationController.References
Checklist
Note
Medium Risk
Adds new state-mutating behavior driven by
TransactionControllerevents; incorrect status/type handling or unsubscribe logic could cause missed deletions or lingering subscriptions, though coverage is included via new unit tests.Overview
Adds a new
DelegationController:awaitDeleteDelegationEntrymethod/action that subscribes toTransactionController:transactionStatusUpdatedand, based on transaction type/status (including replacement viareplacedById), deletes a delegation entry and optionally stores a provided replacement entry.Updates the controller’s messenger types and build refs to allow TransactionController events, adds
@metamask/transaction-controlleras a dependency, exports the new action type, and adds a focused test suite covering confirmation, drop/fail/reject/cancel, replacement chaining, and unsupported types.Written by Cursor Bugbot for commit a3263e5. This will update automatically on new commits. Configure here.