Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
/asset-summaryand/market-overviewAPI endpoints always return responses wrapped in an{ id, digest }/{ id, report }envelope whereidis a unique UUID identifying the digest. This PR updatesAiDigestServiceto require that envelope shape (removing the bare-response fallback path), extractsidand exposes it asdigestIdon bothMarketInsightsReportandMarketOverview, and makesdigestIda required field on both types. This enables downstream consumers like MM app to include adigest_idproperty in analytics events.References
Checklist
Note
Medium Risk
Introduces a breaking change to
AiDigestService/types by rejecting non-enveloped API responses and makingdigestIdrequired, which can impact downstream consumers expecting the old response shape.Overview
Adds a required
digestIdto AI digest client results.MarketInsightsReportandMarketOverviewnow requiredigestId, sourced from the API envelopeid.Tightens
AiDigestServiceresponse handling. The service now only accepts enveloped responses ({ id, digest }for/asset-summaryand{ id, report }for/market-overview), normalizes them by mergingdigestIdinto the returned object, and treats missing/invalid envelopes asAPI_INVALID_RESPONSE.Tests and the package changelog are updated to reflect the new envelope requirement and
digestIdextraction behavior.Written by Cursor Bugbot for commit a226186. This will update automatically on new commits. Configure here.